You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Deepa Remesh (JIRA)" <de...@db.apache.org> on 2006/02/16 20:46:11 UTC

[jira] Updated: (DERBY-996) storetests/st_derby715.java fails in J2ME in 10.1 branch

     [ http://issues.apache.org/jira/browse/DERBY-996?page=all ]

Deepa Remesh updated DERBY-996:
-------------------------------

    Attachment: derby-996-v1.diff

Attaching a patch 'derby-996-v1.diff' for 10.1 branch to resolve failure in storetests/st_derby715.java. This patch modifies only one file:
M      java\testing\org\apache\derbyTesting\functionTests\tests\storetests\st_schema_app.properties

The database for st_derby715 test gets created by a previous test (st_schema.sql).  This test was disabled in j2me. The patch removes "runwithfoundation=false" from st_schema_app.properties. It adds ij.dataSource.* properties and changes 'database' property to 'ij.database' so that test harness will use the datasource properties when getting the initial connection.

Something I noticed when creating this patch is the the test st_schema.sql is empty. It just has the following comment: 
-- add the sample database schema

I am curious to know the purpose of this test. Is it just to create database for the subsequent tests or is it doing something else under the covers? 

With this patch, I have run storetests suite with j9_foundation VM as well as with Sun JDK 1.4.2. No failures. I would appreciate if a committer can take a look at this patch. Thanks. 




> storetests/st_derby715.java fails in J2ME in 10.1 branch
> --------------------------------------------------------
>
>          Key: DERBY-996
>          URL: http://issues.apache.org/jira/browse/DERBY-996
>      Project: Derby
>         Type: Test
>   Components: Regression Test Failure
>  Environment: IBM WCTME 5.7 j9 foundation
>     Reporter: Deepa Remesh
>     Assignee: Deepa Remesh
>      Fix For: 10.1.3.0
>  Attachments: derby-996-v1.diff
>
> storetests/st_derby715.java fails in J2ME in 10.1 branch with following diff:
> ********* Diff file derbyall/storeall/storetests/st_derby715.diff
> *** Start: st_derby715 jdkJ2ME Foundation Specification v1.0 storeall:storetests 2006-02-11 23:42:11 ***
> 1 del
> < Got a Deadlock.
> 2 del
> < Got a Deadlock.
> 3 del
> < Got a Deadlock.
> 4 del
> < Got a Deadlock.
> 5 del
> < Got a Deadlock.
> 5 add
> > Exception in thread "main" SQL Exception: Database 'wombat' not found.
> Test Failed.
> *** End:   st_derby715 jdkJ2ME Foundation Specification v1.0 storeall:storetests 2006-02-11 23:42:12 ***
> The database used by this test is created by the first test run in storetests suite (st_schema.sql). This test is excluded from J2ME. I'll submit a patch to enable this test in a short while.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Updated: (DERBY-996) storetests/st_derby715.java fails in J2ME in 10.1 branch

Posted by Mike Matrigali <mi...@sbcglobal.net>.
yes, the changes seem fine.  I have not run them in the environment
but your description of the problem and the solution seem good.

Deepa Remesh wrote:

> On 2/16/06, Mike Matrigali <mi...@sbcglobal.net> wrote:
> 
>>it was meant as a place to create schema shared by all the tests
>>in the storetests suite.  As you found it is the first test which
>>is special the "usesystem" suite as running this test creates the
>>db, while the rest just reuse the db.  Given that we sometimes
>>have to disable tests, it probably is ok to leave it as is, as it
>>definitely should run in all environments.
> 
> 
> Thanks for the answer, Mike. Just clarifying I understood correctly.
> So st_schema.sql should be enabled in j2me for any subsequent tests in
> storetests suite to be run in this environment. I just want to clarify
> if you are okay with the changes done by my patch.
> 
> Thanks,
> Deepa
> 

Re: [jira] Updated: (DERBY-996) storetests/st_derby715.java fails in J2ME in 10.1 branch

Posted by Deepa Remesh <dr...@gmail.com>.
On 2/16/06, Mike Matrigali <mi...@sbcglobal.net> wrote:
> it was meant as a place to create schema shared by all the tests
> in the storetests suite.  As you found it is the first test which
> is special the "usesystem" suite as running this test creates the
> db, while the rest just reuse the db.  Given that we sometimes
> have to disable tests, it probably is ok to leave it as is, as it
> definitely should run in all environments.

Thanks for the answer, Mike. Just clarifying I understood correctly.
So st_schema.sql should be enabled in j2me for any subsequent tests in
storetests suite to be run in this environment. I just want to clarify
if you are okay with the changes done by my patch.

Thanks,
Deepa

Re: [jira] Updated: (DERBY-996) storetests/st_derby715.java fails in J2ME in 10.1 branch

Posted by Mike Matrigali <mi...@sbcglobal.net>.
it was meant as a place to create schema shared by all the tests
in the storetests suite.  As you found it is the first test which
is special the "usesystem" suite as running this test creates the
db, while the rest just reuse the db.  Given that we sometimes
have to disable tests, it probably is ok to leave it as is, as it
definitely should run in all environments.

Deepa Remesh (JIRA) wrote:

>      [ http://issues.apache.org/jira/browse/DERBY-996?page=all ]
> 
> Deepa Remesh updated DERBY-996:
> -------------------------------
> 
>     Attachment: derby-996-v1.diff
> 
> Attaching a patch 'derby-996-v1.diff' for 10.1 branch to resolve failure in storetests/st_derby715.java. This patch modifies only one file:
> M      java\testing\org\apache\derbyTesting\functionTests\tests\storetests\st_schema_app.properties
> 
> The database for st_derby715 test gets created by a previous test (st_schema.sql).  This test was disabled in j2me. The patch removes "runwithfoundation=false" from st_schema_app.properties. It adds ij.dataSource.* properties and changes 'database' property to 'ij.database' so that test harness will use the datasource properties when getting the initial connection.
> 
> Something I noticed when creating this patch is the the test st_schema.sql is empty. It just has the following comment: 
> -- add the sample database schema
> 
> I am curious to know the purpose of this test. Is it just to create database for the subsequent tests or is it doing something else under the covers? 
> 
> With this patch, I have run storetests suite with j9_foundation VM as well as with Sun JDK 1.4.2. No failures. I would appreciate if a committer can take a look at this patch. Thanks. 
> 
> 
> 
> 
> 
>>storetests/st_derby715.java fails in J2ME in 10.1 branch
>>--------------------------------------------------------
>>
>>         Key: DERBY-996
>>         URL: http://issues.apache.org/jira/browse/DERBY-996
>>     Project: Derby
>>        Type: Test
>>  Components: Regression Test Failure
>> Environment: IBM WCTME 5.7 j9 foundation
>>    Reporter: Deepa Remesh
>>    Assignee: Deepa Remesh
>>     Fix For: 10.1.3.0
>> Attachments: derby-996-v1.diff
>>
>>storetests/st_derby715.java fails in J2ME in 10.1 branch with following diff:
>>********* Diff file derbyall/storeall/storetests/st_derby715.diff
>>*** Start: st_derby715 jdkJ2ME Foundation Specification v1.0 storeall:storetests 2006-02-11 23:42:11 ***
>>1 del
>>< Got a Deadlock.
>>2 del
>>< Got a Deadlock.
>>3 del
>>< Got a Deadlock.
>>4 del
>>< Got a Deadlock.
>>5 del
>>< Got a Deadlock.
>>5 add
>>
>>>Exception in thread "main" SQL Exception: Database 'wombat' not found.
>>
>>Test Failed.
>>*** End:   st_derby715 jdkJ2ME Foundation Specification v1.0 storeall:storetests 2006-02-11 23:42:12 ***
>>The database used by this test is created by the first test run in storetests suite (st_schema.sql). This test is excluded from J2ME. I'll submit a patch to enable this test in a short while.
> 
>