You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/01/02 14:57:16 UTC

[commons-codec] branch master updated: Breaking binary compatibility should break the build instead of generating a report one might skip reading, especially for PRs.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new 00ea5ee  Breaking binary compatibility should break the build instead of generating a report one might skip reading, especially for PRs.
00ea5ee is described below

commit 00ea5eeb9105b59674cc3cf6c5478e96ee6c1e4e
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jan 2 09:57:12 2021 -0500

    Breaking binary compatibility should break the build instead of
    generating a report one might skip reading, especially for PRs.
---
 .github/workflows/maven.yml | 2 +-
 pom.xml                     | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index ab5b7fb..b5a0f0f 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -45,4 +45,4 @@ jobs:
       with:
         java-version: ${{ matrix.java }}
     - name: Build with Maven
-      run: mvn -V package --file pom.xml --no-transfer-progress
+      run: mvn -V --file pom.xml --no-transfer-progress
diff --git a/pom.xml b/pom.xml
index 9a92dbe..b69e36a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -246,9 +246,6 @@ limitations under the License.
     <checkstyle.version>2.17</checkstyle.version>
     <commons.japicmp.version>0.15.1</commons.japicmp.version>
     <commons.jacoco.version>0.8.6</commons.jacoco.version>
-
-    <!-- generate report even if there are binary incompatible changes -->
-    <commons.japicmp.breakBuildOnBinaryIncompatibleModifications>false</commons.japicmp.breakBuildOnBinaryIncompatibleModifications>
     <japicmp.skip>false</japicmp.skip>
 
     <!-- Commons Release Plugin -->
@@ -261,7 +258,7 @@ limitations under the License.
     <commons.releaseManagerKey>BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567</commons.releaseManagerKey>
   </properties>
   <build>
-    <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check javadoc:javadoc</defaultGoal>
+    <defaultGoal>clean install apache-rat:check japicmp:cmp checkstyle:check javadoc:javadoc</defaultGoal>
     <pluginManagement>
       <plugins>
         <plugin>