You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/09/26 09:55:15 UTC
[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #2522: [CALCITE-4735] Enhance Aggregate-Materialization, when aggcall of query could be expressed by target's grouping (xurenhe)
yanlin-Lynn commented on a change in pull request #2522:
URL: https://github.com/apache/calcite/pull/2522#discussion_r716177327
##########
File path: core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java
##########
@@ -1051,6 +1051,59 @@
sql(mv, query).ok();
}
+ @Test void testAggCallArgExpressedByMvProjs1() {
+ final String mv = ""
+ + "select \"deptno\", \"salary\""
+ + "from \"emps\" group by \"deptno\", \"salary\"";
+ final String query = ""
+ + "select \"deptno\", sum(\"salary\")"
+ + "from \"emps\" group by \"deptno\"";
+ sql(mv, query).ok();
Review comment:
This is not correct, should not match in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org