You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/04/03 10:32:49 UTC
[GitHub] [ignite] ololo3000 opened a new pull request #7620: IGNITE-12828
Fixes NPE during CQ registration with failed deployment.
ololo3000 opened a new pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r405381924
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.processors.continuous.StopRoutineDiscoveryMessage;
+import org.apache.ignite.internal.util.typedef.G;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.lang.IgniteFuture;
+import org.apache.ignite.spi.discovery.DiscoverySpi;
+import org.apache.ignite.spi.discovery.DiscoverySpiCustomMessage;
+import org.apache.ignite.spi.discovery.DiscoverySpiListener;
+import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
+import org.apache.ignite.spi.systemview.view.ContinuousQueryView;
+import org.apache.ignite.spi.systemview.view.SystemView;
+import org.apache.ignite.testframework.GridTestUtils;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.jetbrains.annotations.Nullable;
+import org.junit.Test;
+
+import static org.apache.ignite.cluster.ClusterState.ACTIVE;
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behavior of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class CacheContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_FACTORY_CLS =
+ "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** Counter of nodes that finished processing of {@link StopRoutineDiscoveryMessage}. */
+ private final AtomicInteger stopRoutineMsgCntr = new AtomicInteger();
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ DiscoverySpi spi = new TcpDiscoverySpi() {
+ @Override public void setListener(@Nullable DiscoverySpiListener lsnr) {
+ super.setListener(lsnr == null ? null : new TestDiscoverySpiListener(lsnr, stopRoutineMsgCntr));
+ }
+ };
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setNetworkTimeout(1000);
+ cfg.setDiscoverySpi(spi);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behavior in case of filter deployment obtaining failure.
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ @SuppressWarnings({"ThrowableNotThrown"})
+ public void testContinuousQueryFilterDeploymentFailed() throws Exception {
+ IgniteEx ignite = startGrids(2);
+
+ IgniteEx client = startClientGrid(2);
+
+ ignite.cluster().state(ACTIVE);
+
+ ignite.createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+
+ ContinuousQuery<Integer, Integer> qry = new ContinuousQuery<>();
+
+ Class<Factory<CacheEntryEventFilter<Integer, Integer>>> rmtFilterFactoryCls =
+ (Class<Factory<CacheEntryEventFilter<Integer, Integer>>>)getExternalClassLoader()
+ .loadClass(EXT_FILTER_FACTORY_CLS);
+
+ Factory<CacheEntryEventFilter<Integer, Integer>> rmtFilterFactory = rmtFilterFactoryCls.newInstance();
+
+ qry.setRemoteFilterFactory(rmtFilterFactory);
+
+ spi(grid(1)).blockMessages((node, msg) -> msg instanceof GridDeploymentRequest);
+
+ assertThrowsAnyCause(
+ log,
+ () -> client.cache(DEFAULT_CACHE_NAME).query(qry),
+ CacheException.class,
+ "Failed to start continuous query."
+ );
+
+ checkContinuousQueryAborted();
+ }
+
+ /**
+ * Awaits handling of stop routine message on all cluster nodes and checks that CQ registraition was fully aborted.
+ */
+ private void checkContinuousQueryAborted() throws Exception {
+ List<Ignite> grids = G.allGrids();
+
+ GridTestUtils.waitForCondition(() -> stopRoutineMsgCntr.get() == grids.size(), getTestTimeout());
+
+ assertTrue(grids.stream().allMatch(ignite -> {
+ SystemView<ContinuousQueryView> locQrys = ((IgniteEx)ignite).context().systemView().view(CQ_SYS_VIEW);
+
+ return locQrys.size() == 0;
+ }));
+
+ }
+
+ /**
+ * Wrapper for {@link DiscoverySpiListener} with ability to update specified counter for every handled
+ * {@link StopRoutineDiscoveryMessage}.
+ */
+ private static class TestDiscoverySpiListener implements DiscoverySpiListener {
Review comment:
`GridTestUtils.DiscoverySpiListenerWrapper` can be reused
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov merged pull request #7620: IGNITE-12828 Fixes NPE
during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r403219982
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/ContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behaviour of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class ContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_CLS = "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setPeerClassLoadingEnabled(true);
+ cfg.setNetworkTimeout(1000);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behaviour in case of filter deployment obtaining failure.
+ */
+ @Test
+ @SuppressWarnings({"ThrowableNotThrown"})
+ public void testContinuousQueryFilterDeploymentFailed() throws Exception {
+ startGrids(2).cluster().state(ClusterState.ACTIVE);
+
+ grid(0).createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+
+ ContinuousQuery<Integer, Integer> qry = new ContinuousQuery<>();
+
+ Class<Factory<? extends CacheEntryEventFilter<Integer, Integer>>> filterFactoryCls =
Review comment:
`? extends ` is unnecessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r405401699
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.processors.continuous.StopRoutineDiscoveryMessage;
+import org.apache.ignite.internal.util.typedef.G;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.lang.IgniteFuture;
+import org.apache.ignite.spi.discovery.DiscoverySpi;
+import org.apache.ignite.spi.discovery.DiscoverySpiCustomMessage;
+import org.apache.ignite.spi.discovery.DiscoverySpiListener;
+import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
+import org.apache.ignite.spi.systemview.view.ContinuousQueryView;
+import org.apache.ignite.spi.systemview.view.SystemView;
+import org.apache.ignite.testframework.GridTestUtils;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.jetbrains.annotations.Nullable;
+import org.junit.Test;
+
+import static org.apache.ignite.cluster.ClusterState.ACTIVE;
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behavior of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class CacheContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_FACTORY_CLS =
+ "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** Counter of nodes that finished processing of {@link StopRoutineDiscoveryMessage}. */
+ private final AtomicInteger stopRoutineMsgCntr = new AtomicInteger();
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ DiscoverySpi spi = new TcpDiscoverySpi() {
+ @Override public void setListener(@Nullable DiscoverySpiListener lsnr) {
+ super.setListener(lsnr == null ? null : new TestDiscoverySpiListener(lsnr, stopRoutineMsgCntr));
+ }
+ };
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setNetworkTimeout(1000);
+ cfg.setDiscoverySpi(spi);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behavior in case of filter deployment obtaining failure.
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ @SuppressWarnings({"ThrowableNotThrown"})
+ public void testContinuousQueryFilterDeploymentFailed() throws Exception {
+ IgniteEx ignite = startGrids(2);
+
+ IgniteEx client = startClientGrid(2);
+
+ ignite.cluster().state(ACTIVE);
+
+ ignite.createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+
+ ContinuousQuery<Integer, Integer> qry = new ContinuousQuery<>();
+
+ Class<Factory<CacheEntryEventFilter<Integer, Integer>>> rmtFilterFactoryCls =
+ (Class<Factory<CacheEntryEventFilter<Integer, Integer>>>)getExternalClassLoader()
+ .loadClass(EXT_FILTER_FACTORY_CLS);
+
+ Factory<CacheEntryEventFilter<Integer, Integer>> rmtFilterFactory = rmtFilterFactoryCls.newInstance();
+
+ qry.setRemoteFilterFactory(rmtFilterFactory);
+
+ spi(grid(1)).blockMessages((node, msg) -> msg instanceof GridDeploymentRequest);
+
+ assertThrowsAnyCause(
+ log,
+ () -> client.cache(DEFAULT_CACHE_NAME).query(qry),
+ CacheException.class,
+ "Failed to start continuous query."
+ );
+
+ checkContinuousQueryAborted();
+ }
+
+ /**
+ * Awaits handling of stop routine message on all cluster nodes and checks that CQ registraition was fully aborted.
+ */
+ private void checkContinuousQueryAborted() throws Exception {
+ List<Ignite> grids = G.allGrids();
+
+ GridTestUtils.waitForCondition(() -> stopRoutineMsgCntr.get() == grids.size(), getTestTimeout());
+
+ assertTrue(grids.stream().allMatch(ignite -> {
+ SystemView<ContinuousQueryView> locQrys = ((IgniteEx)ignite).context().systemView().view(CQ_SYS_VIEW);
+
+ return locQrys.size() == 0;
+ }));
+
Review comment:
Unnecessary line break
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r405381924
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.processors.continuous.StopRoutineDiscoveryMessage;
+import org.apache.ignite.internal.util.typedef.G;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.lang.IgniteFuture;
+import org.apache.ignite.spi.discovery.DiscoverySpi;
+import org.apache.ignite.spi.discovery.DiscoverySpiCustomMessage;
+import org.apache.ignite.spi.discovery.DiscoverySpiListener;
+import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
+import org.apache.ignite.spi.systemview.view.ContinuousQueryView;
+import org.apache.ignite.spi.systemview.view.SystemView;
+import org.apache.ignite.testframework.GridTestUtils;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.jetbrains.annotations.Nullable;
+import org.junit.Test;
+
+import static org.apache.ignite.cluster.ClusterState.ACTIVE;
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behavior of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class CacheContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_FACTORY_CLS =
+ "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** Counter of nodes that finished processing of {@link StopRoutineDiscoveryMessage}. */
+ private final AtomicInteger stopRoutineMsgCntr = new AtomicInteger();
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ DiscoverySpi spi = new TcpDiscoverySpi() {
+ @Override public void setListener(@Nullable DiscoverySpiListener lsnr) {
+ super.setListener(lsnr == null ? null : new TestDiscoverySpiListener(lsnr, stopRoutineMsgCntr));
+ }
+ };
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setNetworkTimeout(1000);
+ cfg.setDiscoverySpi(spi);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behavior in case of filter deployment obtaining failure.
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ @SuppressWarnings({"ThrowableNotThrown"})
+ public void testContinuousQueryFilterDeploymentFailed() throws Exception {
+ IgniteEx ignite = startGrids(2);
+
+ IgniteEx client = startClientGrid(2);
+
+ ignite.cluster().state(ACTIVE);
+
+ ignite.createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+
+ ContinuousQuery<Integer, Integer> qry = new ContinuousQuery<>();
+
+ Class<Factory<CacheEntryEventFilter<Integer, Integer>>> rmtFilterFactoryCls =
+ (Class<Factory<CacheEntryEventFilter<Integer, Integer>>>)getExternalClassLoader()
+ .loadClass(EXT_FILTER_FACTORY_CLS);
+
+ Factory<CacheEntryEventFilter<Integer, Integer>> rmtFilterFactory = rmtFilterFactoryCls.newInstance();
+
+ qry.setRemoteFilterFactory(rmtFilterFactory);
+
+ spi(grid(1)).blockMessages((node, msg) -> msg instanceof GridDeploymentRequest);
+
+ assertThrowsAnyCause(
+ log,
+ () -> client.cache(DEFAULT_CACHE_NAME).query(qry),
+ CacheException.class,
+ "Failed to start continuous query."
+ );
+
+ checkContinuousQueryAborted();
+ }
+
+ /**
+ * Awaits handling of stop routine message on all cluster nodes and checks that CQ registraition was fully aborted.
+ */
+ private void checkContinuousQueryAborted() throws Exception {
+ List<Ignite> grids = G.allGrids();
+
+ GridTestUtils.waitForCondition(() -> stopRoutineMsgCntr.get() == grids.size(), getTestTimeout());
+
+ assertTrue(grids.stream().allMatch(ignite -> {
+ SystemView<ContinuousQueryView> locQrys = ((IgniteEx)ignite).context().systemView().view(CQ_SYS_VIEW);
+
+ return locQrys.size() == 0;
+ }));
+
+ }
+
+ /**
+ * Wrapper for {@link DiscoverySpiListener} with ability to update specified counter for every handled
+ * {@link StopRoutineDiscoveryMessage}.
+ */
+ private static class TestDiscoverySpiListener implements DiscoverySpiListener {
Review comment:
`GridTestUtils.DiscoverySpiListenerWrapper` can be reused
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r405383115
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.processors.continuous.StopRoutineDiscoveryMessage;
+import org.apache.ignite.internal.util.typedef.G;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.lang.IgniteFuture;
+import org.apache.ignite.spi.discovery.DiscoverySpi;
+import org.apache.ignite.spi.discovery.DiscoverySpiCustomMessage;
+import org.apache.ignite.spi.discovery.DiscoverySpiListener;
+import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
+import org.apache.ignite.spi.systemview.view.ContinuousQueryView;
+import org.apache.ignite.spi.systemview.view.SystemView;
+import org.apache.ignite.testframework.GridTestUtils;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.jetbrains.annotations.Nullable;
+import org.junit.Test;
+
+import static org.apache.ignite.cluster.ClusterState.ACTIVE;
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behavior of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class CacheContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_FACTORY_CLS =
+ "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** Counter of nodes that finished processing of {@link StopRoutineDiscoveryMessage}. */
+ private final AtomicInteger stopRoutineMsgCntr = new AtomicInteger();
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ DiscoverySpi spi = new TcpDiscoverySpi() {
+ @Override public void setListener(@Nullable DiscoverySpiListener lsnr) {
+ super.setListener(lsnr == null ? null : new TestDiscoverySpiListener(lsnr, stopRoutineMsgCntr));
+ }
+ };
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setNetworkTimeout(1000);
+ cfg.setDiscoverySpi(spi);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behavior in case of filter deployment obtaining failure.
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ @SuppressWarnings({"ThrowableNotThrown"})
+ public void testContinuousQueryFilterDeploymentFailed() throws Exception {
+ IgniteEx ignite = startGrids(2);
+
+ IgniteEx client = startClientGrid(2);
+
+ ignite.cluster().state(ACTIVE);
+
+ ignite.createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+
+ ContinuousQuery<Integer, Integer> qry = new ContinuousQuery<>();
+
+ Class<Factory<CacheEntryEventFilter<Integer, Integer>>> rmtFilterFactoryCls =
+ (Class<Factory<CacheEntryEventFilter<Integer, Integer>>>)getExternalClassLoader()
+ .loadClass(EXT_FILTER_FACTORY_CLS);
+
+ Factory<CacheEntryEventFilter<Integer, Integer>> rmtFilterFactory = rmtFilterFactoryCls.newInstance();
+
+ qry.setRemoteFilterFactory(rmtFilterFactory);
+
+ spi(grid(1)).blockMessages((node, msg) -> msg instanceof GridDeploymentRequest);
+
+ assertThrowsAnyCause(
+ log,
+ () -> client.cache(DEFAULT_CACHE_NAME).query(qry),
+ CacheException.class,
+ "Failed to start continuous query."
+ );
+
+ checkContinuousQueryAborted();
+ }
+
+ /**
+ * Awaits handling of stop routine message on all cluster nodes and checks that CQ registraition was fully aborted.
+ */
+ private void checkContinuousQueryAborted() throws Exception {
+ List<Ignite> grids = G.allGrids();
+
+ GridTestUtils.waitForCondition(() -> stopRoutineMsgCntr.get() == grids.size(), getTestTimeout());
+
+ assertTrue(grids.stream().allMatch(ignite -> {
+ SystemView<ContinuousQueryView> locQrys = ((IgniteEx)ignite).context().systemView().view(CQ_SYS_VIEW);
+
+ return locQrys.size() == 0;
+ }));
+
+ }
+
+ /**
+ * Wrapper for {@link DiscoverySpiListener} with ability to update specified counter for every handled
+ * {@link StopRoutineDiscoveryMessage}.
+ */
+ private static class TestDiscoverySpiListener implements DiscoverySpiListener {
+ /** Listener to which all calls is delegated. */
+ private final DiscoverySpiListener lsnr;
+
+ /** Counter of handled {@link StopRoutineDiscoveryMessage}. */
+ private final AtomicInteger cntr;
+
+ /** */
+ private TestDiscoverySpiListener(DiscoverySpiListener lsnr, AtomicInteger cntr) {
+ this.lsnr = lsnr;
+ this.cntr = cntr;
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onLocalNodeInitialized(ClusterNode locNode) {
+ lsnr.onLocalNodeInitialized(locNode);
+ }
+
+ /** {@inheritDoc} */
+ @Override public IgniteFuture<?> onDiscovery(
+ int type,
+ long topVer,
+ ClusterNode node,
+ Collection<ClusterNode> topSnapshot,
+ @Nullable Map<Long, Collection<ClusterNode>> topHist,
+ @Nullable DiscoverySpiCustomMessage data
+ ) {
+ IgniteFuture<?> fut = lsnr.onDiscovery(type, topVer, node, topSnapshot, topHist, data);
+
+ DiscoveryCustomMessage customMsg = data == null ?
+ null : (DiscoveryCustomMessage)U.field(data, "delegate");
+
+ if (customMsg instanceof StopRoutineDiscoveryMessage)
Review comment:
Maybe ack message (`StopRoutineAckDiscoveryMessage`) should be checked?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] ololo3000 commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
ololo3000 commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r405416255
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.processors.continuous.StopRoutineDiscoveryMessage;
+import org.apache.ignite.internal.util.typedef.G;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.lang.IgniteFuture;
+import org.apache.ignite.spi.discovery.DiscoverySpi;
+import org.apache.ignite.spi.discovery.DiscoverySpiCustomMessage;
+import org.apache.ignite.spi.discovery.DiscoverySpiListener;
+import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
+import org.apache.ignite.spi.systemview.view.ContinuousQueryView;
+import org.apache.ignite.spi.systemview.view.SystemView;
+import org.apache.ignite.testframework.GridTestUtils;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.jetbrains.annotations.Nullable;
+import org.junit.Test;
+
+import static org.apache.ignite.cluster.ClusterState.ACTIVE;
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behavior of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class CacheContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_FACTORY_CLS =
+ "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** Counter of nodes that finished processing of {@link StopRoutineDiscoveryMessage}. */
+ private final AtomicInteger stopRoutineMsgCntr = new AtomicInteger();
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ DiscoverySpi spi = new TcpDiscoverySpi() {
+ @Override public void setListener(@Nullable DiscoverySpiListener lsnr) {
+ super.setListener(lsnr == null ? null : new TestDiscoverySpiListener(lsnr, stopRoutineMsgCntr));
+ }
+ };
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setNetworkTimeout(1000);
+ cfg.setDiscoverySpi(spi);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behavior in case of filter deployment obtaining failure.
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ @SuppressWarnings({"ThrowableNotThrown"})
+ public void testContinuousQueryFilterDeploymentFailed() throws Exception {
+ IgniteEx ignite = startGrids(2);
+
+ IgniteEx client = startClientGrid(2);
+
+ ignite.cluster().state(ACTIVE);
+
+ ignite.createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+
+ ContinuousQuery<Integer, Integer> qry = new ContinuousQuery<>();
+
+ Class<Factory<CacheEntryEventFilter<Integer, Integer>>> rmtFilterFactoryCls =
+ (Class<Factory<CacheEntryEventFilter<Integer, Integer>>>)getExternalClassLoader()
+ .loadClass(EXT_FILTER_FACTORY_CLS);
+
+ Factory<CacheEntryEventFilter<Integer, Integer>> rmtFilterFactory = rmtFilterFactoryCls.newInstance();
+
+ qry.setRemoteFilterFactory(rmtFilterFactory);
+
+ spi(grid(1)).blockMessages((node, msg) -> msg instanceof GridDeploymentRequest);
+
+ assertThrowsAnyCause(
+ log,
+ () -> client.cache(DEFAULT_CACHE_NAME).query(qry),
+ CacheException.class,
+ "Failed to start continuous query."
+ );
+
+ checkContinuousQueryAborted();
+ }
+
+ /**
+ * Awaits handling of stop routine message on all cluster nodes and checks that CQ registraition was fully aborted.
+ */
+ private void checkContinuousQueryAborted() throws Exception {
+ List<Ignite> grids = G.allGrids();
+
+ GridTestUtils.waitForCondition(() -> stopRoutineMsgCntr.get() == grids.size(), getTestTimeout());
+
+ assertTrue(grids.stream().allMatch(ignite -> {
+ SystemView<ContinuousQueryView> locQrys = ((IgniteEx)ignite).context().systemView().view(CQ_SYS_VIEW);
+
+ return locQrys.size() == 0;
+ }));
+
Review comment:
Thanks. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r403212899
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/ContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behaviour of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class ContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_CLS = "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setPeerClassLoadingEnabled(true);
+ cfg.setNetworkTimeout(1000);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behaviour in case of filter deployment obtaining failure.
Review comment:
typo: `behavior`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r403210708
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/continuous/GridContinuousProcessor.java
##########
@@ -1472,14 +1472,16 @@ private void processStartRequest(ClusterNode node, StartRoutineDiscoveryMessage
}
// Load partition counters.
- if (hnd.isQuery()) {
+ if (err == null && hnd.isQuery()) {
GridCacheProcessor proc = ctx.cache();
if (proc != null) {
GridCacheAdapter cache = ctx.cache().internalCache(hnd.cacheName());
- if (cache != null && !cache.isLocal() && cache.context().userCache())
- req.addUpdateCounters(ctx.localNodeId(), hnd.updateCounters());
+ Map<Integer, T2<Long, Long>> cntrs = hnd.updateCounters();
+
+ if (cache != null && cntrs != null && !cache.isLocal() && cache.context().userCache())
Review comment:
Is `err == null` not enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r403220877
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/ContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behaviour of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class ContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_CLS = "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setPeerClassLoadingEnabled(true);
+ cfg.setNetworkTimeout(1000);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behaviour in case of filter deployment obtaining failure.
+ */
+ @Test
+ @SuppressWarnings({"ThrowableNotThrown"})
+ public void testContinuousQueryFilterDeploymentFailed() throws Exception {
+ startGrids(2).cluster().state(ClusterState.ACTIVE);
+
+ grid(0).createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+
+ ContinuousQuery<Integer, Integer> qry = new ContinuousQuery<>();
+
+ Class<Factory<? extends CacheEntryEventFilter<Integer, Integer>>> filterFactoryCls =
+ (Class<Factory<? extends CacheEntryEventFilter<Integer, Integer>>>) getExternalClassLoader()
Review comment:
Whitespace after the cast is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] ololo3000 commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
ololo3000 commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r403898372
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behavior of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class CacheContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_FACTORY_CLS =
+ "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setNetworkTimeout(1000);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behavior in case of filter deployment obtaining failure.
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ @SuppressWarnings({"ThrowableNotThrown"})
+ public void testContinuousQueryFilterDeploymentFailed() throws Exception {
+ startGrids(2).cluster().state(ClusterState.ACTIVE);
+
+ grid(0).createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+
+ ContinuousQuery<Integer, Integer> qry = new ContinuousQuery<>();
+
+ Class<Factory<CacheEntryEventFilter<Integer, Integer>>> remoteFilterFactoryCls =
+ (Class<Factory<CacheEntryEventFilter<Integer, Integer>>>)getExternalClassLoader()
+ .loadClass(EXT_FILTER_FACTORY_CLS);
+
+ Factory<CacheEntryEventFilter<Integer, Integer>> remoteFilterFactory = remoteFilterFactoryCls.newInstance();
Review comment:
Thanks. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r403213314
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/ContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behaviour of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class ContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_CLS = "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setPeerClassLoadingEnabled(true);
+ cfg.setNetworkTimeout(1000);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behaviour in case of filter deployment obtaining failure.
+ */
Review comment:
Missed `@throws`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r405383115
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
+import org.apache.ignite.internal.processors.continuous.StopRoutineDiscoveryMessage;
+import org.apache.ignite.internal.util.typedef.G;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.lang.IgniteFuture;
+import org.apache.ignite.spi.discovery.DiscoverySpi;
+import org.apache.ignite.spi.discovery.DiscoverySpiCustomMessage;
+import org.apache.ignite.spi.discovery.DiscoverySpiListener;
+import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
+import org.apache.ignite.spi.systemview.view.ContinuousQueryView;
+import org.apache.ignite.spi.systemview.view.SystemView;
+import org.apache.ignite.testframework.GridTestUtils;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.jetbrains.annotations.Nullable;
+import org.junit.Test;
+
+import static org.apache.ignite.cluster.ClusterState.ACTIVE;
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behavior of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class CacheContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_FACTORY_CLS =
+ "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** Counter of nodes that finished processing of {@link StopRoutineDiscoveryMessage}. */
+ private final AtomicInteger stopRoutineMsgCntr = new AtomicInteger();
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ DiscoverySpi spi = new TcpDiscoverySpi() {
+ @Override public void setListener(@Nullable DiscoverySpiListener lsnr) {
+ super.setListener(lsnr == null ? null : new TestDiscoverySpiListener(lsnr, stopRoutineMsgCntr));
+ }
+ };
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setNetworkTimeout(1000);
+ cfg.setDiscoverySpi(spi);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behavior in case of filter deployment obtaining failure.
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ @SuppressWarnings({"ThrowableNotThrown"})
+ public void testContinuousQueryFilterDeploymentFailed() throws Exception {
+ IgniteEx ignite = startGrids(2);
+
+ IgniteEx client = startClientGrid(2);
+
+ ignite.cluster().state(ACTIVE);
+
+ ignite.createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+
+ ContinuousQuery<Integer, Integer> qry = new ContinuousQuery<>();
+
+ Class<Factory<CacheEntryEventFilter<Integer, Integer>>> rmtFilterFactoryCls =
+ (Class<Factory<CacheEntryEventFilter<Integer, Integer>>>)getExternalClassLoader()
+ .loadClass(EXT_FILTER_FACTORY_CLS);
+
+ Factory<CacheEntryEventFilter<Integer, Integer>> rmtFilterFactory = rmtFilterFactoryCls.newInstance();
+
+ qry.setRemoteFilterFactory(rmtFilterFactory);
+
+ spi(grid(1)).blockMessages((node, msg) -> msg instanceof GridDeploymentRequest);
+
+ assertThrowsAnyCause(
+ log,
+ () -> client.cache(DEFAULT_CACHE_NAME).query(qry),
+ CacheException.class,
+ "Failed to start continuous query."
+ );
+
+ checkContinuousQueryAborted();
+ }
+
+ /**
+ * Awaits handling of stop routine message on all cluster nodes and checks that CQ registraition was fully aborted.
+ */
+ private void checkContinuousQueryAborted() throws Exception {
+ List<Ignite> grids = G.allGrids();
+
+ GridTestUtils.waitForCondition(() -> stopRoutineMsgCntr.get() == grids.size(), getTestTimeout());
+
+ assertTrue(grids.stream().allMatch(ignite -> {
+ SystemView<ContinuousQueryView> locQrys = ((IgniteEx)ignite).context().systemView().view(CQ_SYS_VIEW);
+
+ return locQrys.size() == 0;
+ }));
+
+ }
+
+ /**
+ * Wrapper for {@link DiscoverySpiListener} with ability to update specified counter for every handled
+ * {@link StopRoutineDiscoveryMessage}.
+ */
+ private static class TestDiscoverySpiListener implements DiscoverySpiListener {
+ /** Listener to which all calls is delegated. */
+ private final DiscoverySpiListener lsnr;
+
+ /** Counter of handled {@link StopRoutineDiscoveryMessage}. */
+ private final AtomicInteger cntr;
+
+ /** */
+ private TestDiscoverySpiListener(DiscoverySpiListener lsnr, AtomicInteger cntr) {
+ this.lsnr = lsnr;
+ this.cntr = cntr;
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onLocalNodeInitialized(ClusterNode locNode) {
+ lsnr.onLocalNodeInitialized(locNode);
+ }
+
+ /** {@inheritDoc} */
+ @Override public IgniteFuture<?> onDiscovery(
+ int type,
+ long topVer,
+ ClusterNode node,
+ Collection<ClusterNode> topSnapshot,
+ @Nullable Map<Long, Collection<ClusterNode>> topHist,
+ @Nullable DiscoverySpiCustomMessage data
+ ) {
+ IgniteFuture<?> fut = lsnr.onDiscovery(type, topVer, node, topSnapshot, topHist, data);
+
+ DiscoveryCustomMessage customMsg = data == null ?
+ null : (DiscoveryCustomMessage)U.field(data, "delegate");
+
+ if (customMsg instanceof StopRoutineDiscoveryMessage)
Review comment:
Maybe ack message (`StopRoutineAckDiscoveryMessage`) should be checked?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7620:
IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7620: IGNITE-12828 Fixes NPE during CQ registration with failed deployment.
URL: https://github.com/apache/ignite/pull/7620#discussion_r403743329
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryFilterDeploymentFailedTest.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.query.continuous;
+
+import javax.cache.CacheException;
+import javax.cache.configuration.Factory;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cluster.ClusterState;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.TestRecordingCommunicationSpi;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+import static org.apache.ignite.internal.TestRecordingCommunicationSpi.spi;
+import static org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.CQ_SYS_VIEW;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause;
+
+/**
+ * Tests the behavior of continuous query registration in case the remote node failed to obtain the filter deployment.
+ */
+public class CacheContinuousQueryFilterDeploymentFailedTest extends GridCommonAbstractTest {
+ /** The name of the CQ filter factory class. Its obtaining on a non-local node requires P2P class loading. */
+ private static final String EXT_FILTER_FACTORY_CLS =
+ "org.apache.ignite.tests.p2p.CacheDeploymentEntryEventFilterFactory";
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+ IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
+
+ cfg.setCommunicationSpi(new TestRecordingCommunicationSpi());
+ cfg.setNetworkTimeout(1000);
+
+ return cfg;
+ }
+
+ /**
+ * Tests continuous query behavior in case of filter deployment obtaining failure.
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ @SuppressWarnings({"ThrowableNotThrown"})
+ public void testContinuousQueryFilterDeploymentFailed() throws Exception {
+ startGrids(2).cluster().state(ClusterState.ACTIVE);
+
+ grid(0).createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+
+ ContinuousQuery<Integer, Integer> qry = new ContinuousQuery<>();
+
+ Class<Factory<CacheEntryEventFilter<Integer, Integer>>> remoteFilterFactoryCls =
+ (Class<Factory<CacheEntryEventFilter<Integer, Integer>>>)getExternalClassLoader()
+ .loadClass(EXT_FILTER_FACTORY_CLS);
+
+ Factory<CacheEntryEventFilter<Integer, Integer>> remoteFilterFactory = remoteFilterFactoryCls.newInstance();
Review comment:
Let's use a shortened form `rmt`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services