[GitHub] [ozone] symious commented on a change in pull request #2250: HDDS-5235. Add precheck to avoid ContainerHealthTask setting Deleted containers to Missing state

[GitBox <gi...@apache.org>]

symious commented on a change in pull request #2250:
URL: https://github.com/apache/ozone/pull/2250#discussion_r643611547



##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java
##########
@@ -185,6 +200,35 @@ private void processContainer(ContainerInfo container, long currentTime) {
     }
   }
 
+  private boolean containerDeletedInSCM(ContainerInfo containerInfo) {
+    try {
+      ContainerWithPipeline containerWithPipeline =
+          scmClient.getContainerWithPipeline(containerInfo.getContainerID());

Review comment:
       I think `ContainerManager` is persisting the state already? When the event of DELETE and CLEANUP event was sent, the state changes should have been stored in Rocksdb?
   ```
             containerManager.updateContainerState(containerInfo.containerID(),
                 HddsProtos.LifeCycleEvent.DELETE);
             containerManager.updateContainerState(containerInfo.containerID(),
                 HddsProtos.LifeCycleEvent.CLEANUP);
   ```            




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org