You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Erik Bergenholtz <eb...@hortonworks.com> on 2015/06/05 22:09:47 UTC

Review Request 35149: Automatically creates user's trash directory on hdfs if does not exist

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35149/
-----------------------------------------------------------

Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.


Bugs: AMBARI-11735
    https://issues.apache.org/jira/browse/AMBARI-11735


Repository: ambari


Description
-------

Creates trash dir and issues better error messages. Also increments view version to 1.0.0.


Diffs
-----

  contrib/views/files/pom.xml 1cac902 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java fd07da6 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java 073f13a 
  contrib/views/files/src/main/resources/view.xml 1c8991e 

Diff: https://reviews.apache.org/r/35149/diff/


Testing
-------

Local Unit Tests and deployment of view on live cluster.


Thanks,

Erik Bergenholtz


Re: Review Request 35149: Automatically creates user's trash directory on hdfs if does not exist

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35149/#review86836
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On June 5, 2015, 8:09 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35149/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 8:09 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11735
>     https://issues.apache.org/jira/browse/AMBARI-11735
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Creates trash dir and issues better error messages. Also increments view version to 1.0.0.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml 1cac902 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java fd07da6 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java 073f13a 
>   contrib/views/files/src/main/resources/view.xml 1c8991e 
> 
> Diff: https://reviews.apache.org/r/35149/diff/
> 
> 
> Testing
> -------
> 
> Local Unit Tests and deployment of view on live cluster.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>


Re: Review Request 35149: Automatically creates user's trash directory on hdfs if does not exist

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35149/#review86837
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Nettleton


On June 5, 2015, 8:09 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35149/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 8:09 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11735
>     https://issues.apache.org/jira/browse/AMBARI-11735
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Creates trash dir and issues better error messages. Also increments view version to 1.0.0.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml 1cac902 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java fd07da6 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java 073f13a 
>   contrib/views/files/src/main/resources/view.xml 1c8991e 
> 
> Diff: https://reviews.apache.org/r/35149/diff/
> 
> 
> Testing
> -------
> 
> Local Unit Tests and deployment of view on live cluster.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>


Re: Review Request 35149: Automatically creates user's trash directory on hdfs if does not exist

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35149/#review86958
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Levas


On June 5, 2015, 4:09 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35149/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 4:09 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11735
>     https://issues.apache.org/jira/browse/AMBARI-11735
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Creates trash dir and issues better error messages. Also increments view version to 1.0.0.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml 1cac902 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java fd07da6 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java 073f13a 
>   contrib/views/files/src/main/resources/view.xml 1c8991e 
> 
> Diff: https://reviews.apache.org/r/35149/diff/
> 
> 
> Testing
> -------
> 
> Local Unit Tests and deployment of view on live cluster.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>