You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2026/03/02 08:38:23 UTC
[PR] [CELEBORN-2272] Add LZ4TPCDSDataBenchmark [celeborn]
pan3793 opened a new pull request, #3613:
URL: https://github.com/apache/celeborn/pull/3613
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Add LZ4TPCDSDataBenchmark, use TPC-DS data to measure compression/decompression perf.
### Why are the changes needed?
Provide benchmark reports to measure performance change when upgrading lz4-java.
### Does this PR resolve a correctness bug?
<!-- Yes/No. (Note: If yes, committer will add `correctness` label to current pull request). -->
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
See benchmark reports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2272] Add LZ4TPCDSDataBenchmark [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #3613:
URL: https://github.com/apache/celeborn/pull/3613#discussion_r2871168620
##########
client/benchmarks/LZ4TPCDSDataBenchmark-jdk17-results.txt:
##########
@@ -0,0 +1,53 @@
+================================================================================================
+Benchmark LZ4CompressionCodec
+================================================================================================
+
+OpenJDK 64-Bit Server VM 17.0.15+6-LTS on Linux 6.17.9-76061709-generic
+Intel(R) Core(TM) i5-9500 CPU @ 3.00GHz
Review Comment:
Since we don't have infrastructure like Spark to run benchmarks in GHA yet, we must run it on the same hardware to measure perf change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2272] Add LZ4TPCDSDataBenchmark [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3613:
URL: https://github.com/apache/celeborn/pull/3613#issuecomment-3983962166
Thanks. Merged to main(v0.7.0) and branch-0.6(v0.6.3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2272] Add LZ4TPCDSDataBenchmark [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #3613:
URL: https://github.com/apache/celeborn/pull/3613#discussion_r2871168620
##########
client/benchmarks/LZ4TPCDSDataBenchmark-jdk17-results.txt:
##########
@@ -0,0 +1,53 @@
+================================================================================================
+Benchmark LZ4CompressionCodec
+================================================================================================
+
+OpenJDK 64-Bit Server VM 17.0.15+6-LTS on Linux 6.17.9-76061709-generic
+Intel(R) Core(TM) i5-9500 CPU @ 3.00GHz
Review Comment:
Since we don't have infrastructure like Spark to run benchmarks in GHA yet, we must run on the same hardware to measure perf change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2272] Add LZ4TPCDSDataBenchmark [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #3613:
URL: https://github.com/apache/celeborn/pull/3613#issuecomment-3983065193
@eolivelli thank you for taking a look. Currently, this is used for CELEBORN-2218 to detect potential performance change on lz4-java upgrading (because I observed a performance drop in Spark use cases, see SPARK-54571, so it would be good to check the impact of Celeborn)
> Maybe we should advertise this on the website ?
Maybe it is worth mentioning it in the developer docs, we can refer to how Spark does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2272] Add LZ4TPCDSDataBenchmark [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3613: [CELEBORN-2272] Add LZ4TPCDSDataBenchmark
URL: https://github.com/apache/celeborn/pull/3613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org