You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:46:31 UTC

Review Request 66160: Renamed `disk_profile` files to `disk_profile_adatpor`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66160/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.


Repository: mesos


Description
-------

This is a refactoring work to complete renaming from `DiskProfile` to
`DiskProfileAdaptor`.


Diffs
-----

  include/mesos/mesos.proto e6ba3746456c9241ceaefac39200f68562dd5cb9 
  include/mesos/module/disk_profile.hpp 3a321504c25d85911f05ba70332ecdb4090a213b 
  include/mesos/resource_provider/storage/disk_profile.hpp fa1a4fcdac2163e0811eb04423af22701fef2a69 
  include/mesos/v1/mesos.proto 30d4d35e865db2af1ba85b12e2b5b0e499ef8de8 
  src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7 
  src/resource_provider/storage/disk_profile.cpp ba195cb0fa89f95135a20d25c98e5825f057c75e 
  src/resource_provider/storage/provider.cpp bb19ed4b6b1b8f5f6b327461a737517497c8c38e 
  src/resource_provider/storage/uri_disk_profile.hpp 22e9d8bee0c82807c8b06ef65751496fcd880acf 
  src/resource_provider/storage/uri_disk_profile.cpp 665798fdb085ea34f93bd287fe6f9ab29a265cbf 
  src/slave/slave.cpp 915d4f1bbd642ca5d2587cfdd846262cb7e08788 
  src/tests/disk_profile_tests.cpp 577ccfe9614009ba4178886c100de22ff12047b6 
  src/tests/storage_local_resource_provider_tests.cpp 264d42b57fe1a8ea04c1de0a10112878c7b45d39 


Diff: https://reviews.apache.org/r/66160/diff/1/


Testing
-------

`sudo make check`

`make distcheck` with and without `--enable-grpc`


Thanks,

Chun-Hung Hsiao

Re: Review Request 66160: Renamed `*disk_profile.?pp` to `*disk_profile_adatpor.?pp`.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66160/#review199653
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On March 21, 2018, 12:47 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66160/
> -----------------------------------------------------------
> 
> (Updated March 21, 2018, 12:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed `*disk_profile.?pp` to `*disk_profile_adatpor.?pp`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e6ba3746456c9241ceaefac39200f68562dd5cb9 
>   include/mesos/module/disk_profile.hpp 3a321504c25d85911f05ba70332ecdb4090a213b 
>   include/mesos/resource_provider/storage/disk_profile.hpp fa1a4fcdac2163e0811eb04423af22701fef2a69 
>   include/mesos/v1/mesos.proto 30d4d35e865db2af1ba85b12e2b5b0e499ef8de8 
>   src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e 
>   src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7 
>   src/resource_provider/storage/disk_profile.cpp ba195cb0fa89f95135a20d25c98e5825f057c75e 
>   src/resource_provider/storage/provider.cpp bb19ed4b6b1b8f5f6b327461a737517497c8c38e 
>   src/resource_provider/storage/uri_disk_profile.hpp 22e9d8bee0c82807c8b06ef65751496fcd880acf 
>   src/resource_provider/storage/uri_disk_profile.cpp 665798fdb085ea34f93bd287fe6f9ab29a265cbf 
>   src/slave/slave.cpp 915d4f1bbd642ca5d2587cfdd846262cb7e08788 
>   src/tests/disk_profile_tests.cpp 577ccfe9614009ba4178886c100de22ff12047b6 
>   src/tests/storage_local_resource_provider_tests.cpp 264d42b57fe1a8ea04c1de0a10112878c7b45d39 
> 
> 
> Diff: https://reviews.apache.org/r/66160/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> `make distcheck` with and without `--enable-grpc`
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 66160: Renamed `*disk_profile.?pp` to `*disk_profile_adatpor.?pp`.

Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66160/
-----------------------------------------------------------

(Updated March 20, 2018, 11:47 p.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.


Changes
-------

Fixed CMake build.


Summary (updated)
-----------------

Renamed `*disk_profile.?pp` to `*disk_profile_adatpor.?pp`.


Repository: mesos


Description (updated)
-------

Renamed `*disk_profile.?pp` to `*disk_profile_adatpor.?pp`.


Diffs (updated)
-----

  include/mesos/mesos.proto e6ba3746456c9241ceaefac39200f68562dd5cb9 
  include/mesos/module/disk_profile.hpp 3a321504c25d85911f05ba70332ecdb4090a213b 
  include/mesos/resource_provider/storage/disk_profile.hpp fa1a4fcdac2163e0811eb04423af22701fef2a69 
  include/mesos/v1/mesos.proto 30d4d35e865db2af1ba85b12e2b5b0e499ef8de8 
  src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e 
  src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7 
  src/resource_provider/storage/disk_profile.cpp ba195cb0fa89f95135a20d25c98e5825f057c75e 
  src/resource_provider/storage/provider.cpp bb19ed4b6b1b8f5f6b327461a737517497c8c38e 
  src/resource_provider/storage/uri_disk_profile.hpp 22e9d8bee0c82807c8b06ef65751496fcd880acf 
  src/resource_provider/storage/uri_disk_profile.cpp 665798fdb085ea34f93bd287fe6f9ab29a265cbf 
  src/slave/slave.cpp 915d4f1bbd642ca5d2587cfdd846262cb7e08788 
  src/tests/disk_profile_tests.cpp 577ccfe9614009ba4178886c100de22ff12047b6 
  src/tests/storage_local_resource_provider_tests.cpp 264d42b57fe1a8ea04c1de0a10112878c7b45d39 


Diff: https://reviews.apache.org/r/66160/diff/2/

Changes: https://reviews.apache.org/r/66160/diff/1-2/


Testing
-------

`sudo make check`

`make distcheck` with and without `--enable-grpc`


Thanks,

Chun-Hung Hsiao