You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2024/03/22 12:30:15 UTC
(superset) 04/06: fix(Dashboard): Add editMode conditional for translate3d fix on charts to allow intended Fullscreen (#27613)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit a2fb13b5227bc6bd51a705a4a150bb975a820a87
Author: Ross Mabbett <92...@users.noreply.github.com>
AuthorDate: Fri Mar 22 00:36:17 2024 -0400
fix(Dashboard): Add editMode conditional for translate3d fix on charts to allow intended Fullscreen (#27613)
(cherry picked from commit 842b0939f6a182a8f7d3c7c893200d93be3a4b0c)
---
superset-frontend/src/dashboard/components/dnd/DragDroppable.jsx | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/dashboard/components/dnd/DragDroppable.jsx b/superset-frontend/src/dashboard/components/dnd/DragDroppable.jsx
index bce458dfe6..b5b7373f40 100644
--- a/superset-frontend/src/dashboard/components/dnd/DragDroppable.jsx
+++ b/superset-frontend/src/dashboard/components/dnd/DragDroppable.jsx
@@ -79,7 +79,9 @@ const DragDroppableStyles = styled.div`
preview expands outside of the bounds of the drag source card, see:
https://github.com/react-dnd/react-dnd/issues/832#issuecomment-442071628
*/
- transform: translate3d(0, 0, 0);
+ &.dragdroppable--edit-mode {
+ transform: translate3d(0, 0, 0);
+ }
&.dragdroppable--dragging {
opacity: 0.2;
@@ -180,6 +182,7 @@ export class UnwrappedDragDroppable extends React.PureComponent {
data-test="dragdroppable-object"
className={cx(
'dragdroppable',
+ editMode && 'dragdroppable--edit-mode',
orientation === 'row' && 'dragdroppable-row',
orientation === 'column' && 'dragdroppable-column',
isDragging && 'dragdroppable--dragging',