You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2018/11/20 13:10:41 UTC

[GitHub] spmallette commented on issue #999: some improvements

spmallette commented on issue #999: some improvements
URL: https://github.com/apache/tinkerpop/pull/999#issuecomment-440267920
 
 
   I think these changes make sense presuming that we don't register the same strategy more than once, which I don't think we do - @dkuppitz please think that one through a bit - is there any situation where we allow for that.  Other than that, initializing the `ArrayList` in `flattenArguments()` and going to `LinkedHashSet` to avoid some looping seem to make sense to me.
   
   All tests pass with `docker/build.sh -t -n -i`
   
   VOTE +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services