You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by sh...@apache.org on 2025/09/18 07:31:36 UTC
(iotdb) branch AuthEnhance updated: remove deprecated code
This is an automated email from the ASF dual-hosted git repository.
shuwenwei pushed a commit to branch AuthEnhance
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/AuthEnhance by this push:
new 10667243d78 remove deprecated code
10667243d78 is described below
commit 10667243d781f08e899fa89b9e21e02bfb34faae
Author: shuwenwei <s1...@gmail.com>
AuthorDate: Thu Sep 18 15:31:24 2025 +0800
remove deprecated code
---
.../main/java/org/apache/iotdb/db/auth/AuthorityChecker.java | 11 -----------
.../plan/relational/security/TreeAccessCheckVisitor.java | 7 ++++++-
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/auth/AuthorityChecker.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/auth/AuthorityChecker.java
index 48b58a9634b..832dc4f2abd 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/auth/AuthorityChecker.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/auth/AuthorityChecker.java
@@ -366,17 +366,6 @@ public class AuthorityChecker {
return authorityFetcher.get().checkRole(username, roleName);
}
- public static TSStatus checkMaintain(String userName) {
- return AuthorityChecker.getTSStatus(
- AuthorityChecker.checkSystemPermission(userName, PrivilegeType.MAINTAIN),
- PrivilegeType.MAINTAIN);
- }
-
- public static TSStatus checkUserIsSystemAdmin(String userName) {
- return AuthorityChecker.getTSStatus(
- AuthorityChecker.checkSystemPermission(userName, PrivilegeType.SYSTEM),
- PrivilegeType.SYSTEM);
- }
public static Collection<PrivilegeType> checkUserHaveSystemPermissions(
String userName, Collection<PrivilegeType> permissions) {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/security/TreeAccessCheckVisitor.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/security/TreeAccessCheckVisitor.java
index 1059f24c76b..b7a6495c8a5 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/security/TreeAccessCheckVisitor.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/security/TreeAccessCheckVisitor.java
@@ -152,7 +152,6 @@ import static org.apache.iotdb.commons.schema.table.Audit.TREE_MODEL_AUDIT_DATAB
import static org.apache.iotdb.db.auth.AuthorityChecker.SUCCEED;
import static org.apache.iotdb.db.queryengine.plan.relational.security.AccessControlImpl.READ_ONLY_DB_ERROR_MSG;
-/** userName in TreeAccessCheckContext will never be SUPER_USER */
public class TreeAccessCheckVisitor extends StatementVisitor<TSStatus, TreeAccessCheckContext> {
@Override
@@ -1077,6 +1076,12 @@ public class TreeAccessCheckVisitor extends StatementVisitor<TSStatus, TreeAcces
return SUCCEED;
}
List<PartialPath> checkedPaths = statement.getPaths();
+ for (PartialPath checkedPath : checkedPaths) {
+ TSStatus status = checkWriteOnReadOnlyPath(checkedPath);
+ if (status.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
+ return status;
+ }
+ }
return AuthorityChecker.getTSStatus(
AuthorityChecker.checkFullPathOrPatternListPermission(
context.userName, checkedPaths, PrivilegeType.WRITE_SCHEMA),