[GitHub] [superset] hughhhh commented on a diff in pull request #20118: feat: Adding additional information to load_chart

[GitBox <gi...@apache.org>]

hughhhh commented on code in PR #20118:
URL: https://github.com/apache/superset/pull/20118#discussion_r876226880


##########
superset-frontend/src/components/Chart/chartAction.js:
##########
@@ -389,6 +389,7 @@ export function exploreJSON(
       ownState,
     });
 
+    const datasourceInfo = formData.datasource.split('__');

Review Comment:
   nit: deconstruct `datasource` then use it in for the split and the payload:
   ```
   const { datasource } = formData;
   // ...
   logEvent(LOG_ACTIONS_LOAD_CHART, {
   // ...
   datasource,
   datasource_id: datasourceInfo[0], 
   datasource_type: datasourceInfo[1],
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org