[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #289: WIP: Daffodil 2192 warnings - nextElementResolver rewrite

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #289: WIP: Daffodil 2192 warnings - nextElementResolver rewrite
URL: https://github.com/apache/incubator-daffodil/pull/289#discussion_r345275997
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/Expression.scala
 ##########
 @@ -1695,7 +1695,12 @@ case class FunctionCallExpression(functionQNameString: String, expressions: List
           case erd: ElementRuntimeData => erd
           case _ => SDE("dfdlx:outputTypeCalcNextSibling can only be defined on an element")
         }
-        val resolver = erd.nextElementResolver
+        val resolver = erd.partialNextElementResolver
+        //
+        // FIXME: This is broken because it is looking outward and upward for enclosing contexts
 
 Review comment:
   remove comments. No longer relevant. The partial resolver is not looking beyond the scope of the current lexically enclosing group. 
   
   This could be a problem if there is a group-ref/def boundary between the "siblings" in this typeCalc pair. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services