You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Karuppayya <gi...@git.apache.org> on 2015/11/25 11:56:26 UTC

[GitHub] incubator-zeppelin pull request: Fix 'create' -> 'cancel' -> 'crea...

GitHub user Karuppayya opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/473

    Fix 'create' -> 'cancel' -> 'create' in  interpreters page

    Fix for the following scenario
    1. click 'create' button in interpreters page. Interpreter creation form shows up
    2. click 'cancel' button in interpreters page. Interprete creation form is hidden
    2.click 'create' button again. Nothiing happens.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Karuppayya/incubator-zeppelin fix-create-intp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/473.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #473
    
----
commit df3159123524e550102fe625555a2dd8c9f63de7
Author: karuppayya <ka...@gmail.com>
Date:   2015-11-25T10:07:12Z

    Fix display of 'new interpreter form'

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix 'create' -> 'cancel' -> 'crea...

Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/473#issuecomment-159868995
  
    tested on local. works fine. LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix 'create' -> 'cancel' -> 'crea...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/473#issuecomment-159884486
  
    LGTM. Works well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix 'create' -> 'cancel' -> 'crea...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/473


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix 'create' -> 'cancel' -> 'crea...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/473#issuecomment-160353253
  
    Thanks @Karuppayya for the fix. LGTM and i'm merging it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---