You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2015/08/10 20:36:50 UTC
Review Request 37308: Added AppcImageManifest protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37308/
-----------------------------------------------------------
Review request for mesos, Ian Downes and Jie Yu.
Bugs: MESOS-3194
https://issues.apache.org/jira/browse/MESOS-3194
Repository: mesos
Description
-------
Derived from /r/34142/.
Diffs
-----
include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807
Diff: https://reviews.apache.org/r/37308/diff/
Testing
-------
Tested along with /r/37310/.
Thanks,
Jiang Yan Xu
Re: Review Request 37308: Added AppcImageManifest protobuf.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37308/#review94953
-----------------------------------------------------------
include/mesos/mesos.proto (line 1402)
<https://reviews.apache.org/r/37308/#comment149681>
Let's remove those fields that are not implemented for now. The JSON->protobuf parsing will fail if those fields are specified. I think that's a simple yet useful behavior (comparing to checking those fields are not set manully).
You many want to drop a TODO somewhere saying that the rest of the fields will be added when they are supported.
- Jie Yu
On Aug. 10, 2015, 6:36 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37308/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 6:36 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: MESOS-3194
> https://issues.apache.org/jira/browse/MESOS-3194
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Derived from /r/34142/.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807
>
> Diff: https://reviews.apache.org/r/37308/diff/
>
>
> Testing
> -------
>
> Tested along with /r/37310/.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 37308: Added AppcImageManifest protobuf.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37308/#review95331
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 13, 2015, 9:24 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37308/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 9:24 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: MESOS-3194
> https://issues.apache.org/jira/browse/MESOS-3194
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Derived from /r/34142/.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807
>
> Diff: https://reviews.apache.org/r/37308/diff/
>
>
> Testing
> -------
>
> Tested along with /r/37310/.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 37308: Added AppcImageManifest protobuf.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37308/
-----------------------------------------------------------
(Updated Aug. 13, 2015, 2:24 p.m.)
Review request for mesos, Ian Downes and Jie Yu.
Changes
-------
Comments.
Bugs: MESOS-3194
https://issues.apache.org/jira/browse/MESOS-3194
Repository: mesos
Description
-------
Derived from /r/34142/.
Diffs (updated)
-----
include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807
Diff: https://reviews.apache.org/r/37308/diff/
Testing
-------
Tested along with /r/37310/.
Thanks,
Jiang Yan Xu