[GitHub] [kvrocks] git-hulk commented on a diff in pull request #1748: Support logging subcompaction job info in event listener

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on code in PR #1748:
URL: https://github.com/apache/kvrocks/pull/1748#discussion_r1321229965


##########
src/storage/event_listener.h:
##########
@@ -31,7 +31,10 @@ class EventListener : public rocksdb::EventListener {
   ~EventListener() override = default;
   void OnFlushBegin(rocksdb::DB *db, const rocksdb::FlushJobInfo &fi) override;
   void OnFlushCompleted(rocksdb::DB *db, const rocksdb::FlushJobInfo &fi) override;
+  void OnCompactionBegin(rocksdb::DB *db, const rocksdb::CompactionJobInfo &ci) override;

Review Comment:
   Yes, I think it makes sense to add this for observing the compaction behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org