You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/07/09 09:17:42 UTC

[GitHub] spark pull request #21156: [SPARK-24087][SQL] Avoid shuffle when join keys a...

Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21156#discussion_r200934272
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
    @@ -334,8 +334,7 @@ abstract class BucketedReadSuite extends QueryTest with SQLTestUtils {
         )
       }
     
    -  // Enable it after fix https://issues.apache.org/jira/browse/SPARK-12704
    -  ignore("avoid shuffle when join keys are a super-set of bucket keys") {
    +  test("avoid shuffle when join keys are a super-set of bucket keys") {
    --- End diff --
    
    can we add more tests with different `BucketSpec` on the two sides?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org