You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jingyun Tian (JIRA)" <ji...@apache.org> on 2018/05/23 09:28:00 UTC
[jira] [Created] (HBASE-20625) refactor some WALCellCodec related
code
Jingyun Tian created HBASE-20625:
------------------------------------
Summary: refactor some WALCellCodec related code
Key: HBASE-20625
URL: https://issues.apache.org/jira/browse/HBASE-20625
Project: HBase
Issue Type: Improvement
Components: wal
Affects Versions: 2.0.0
Reporter: Jingyun Tian
Assignee: Jingyun Tian
Fix For: 3.0.0
Currently I'm working on export HLog to another FileSystem, then I found the code of WALCellCodec and its related classes is not that clean. And there are several TODOs. Thus I tried to refactor the code based one these TODOs. e.g.
{code}
// TODO: it sucks that compression context is in WAL.Entry. It'd be nice if it was here.
// Dictionary could be gotten by enum; initially, based on enum, context would create
// an array of dictionaries.
static class BaosAndCompressor extends ByteArrayOutputStream implements ByteStringCompressor {
public ByteString toByteString() {
// We need this copy to create the ByteString as the byte[] 'buf' is not immutable. We reuse
// them.
return ByteString.copyFrom(this.buf, 0, this.count);
}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)