[GitHub] [apisix] nic-chen commented on a change in pull request #6202: feat: use keepalive in server-info plugin

[GitBox <gi...@apache.org>]

nic-chen commented on a change in pull request #6202:
URL: https://github.com/apache/apisix/pull/6202#discussion_r810495459



##########
File path: apisix/plugins/server-info.lua
##########
@@ -132,51 +124,111 @@ local function get_server_info()
 end
 
 
+local function set(key, value, ttl)
+    local res_new, err = core.etcd.set(key, value, ttl)
+    if not res_new then
+        core.log.error("failed to set server_info: ", err)
+        return 503, {error_msg = err}

Review comment:
       why should we use `503` here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org