You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/04/15 18:13:19 UTC
Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes to
add Solr audit db support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-10503
https://issues.apache.org/jira/browse/AMBARI-10503
Repository: ambari
Description
-------
Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
Diffs
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py f971f74
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 7626de8
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 2a13337
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 9413d8e
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py e5f9679
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py b3baf32
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ac2bc0a
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py c1f365c
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py abc51d5
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
Diff: https://reviews.apache.org/r/33227/diff/
Testing
-------
Tested with an ambari instance running ranger and a solr server running on one of the node.
Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
Thanks,
Gautam Borad
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by Gautam Borad <gb...@gmail.com>.
> On April 15, 2015, 6:19 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py, line 248
> > <https://reviews.apache.org/r/33227/diff/1/?file=930747#file930747line248>
> >
> > Why don't we branch HBASE into a new version that is used for HDP 2.3? Perhaps sync up with Nick Dimiduk who is also refactoring HBASE and needs to branch it anyways because he's adding a component in HDP 2.3.
> > The practice of checking for "is 2.x or higher" inside HDP 2.2 was a hack that we should not perpetuate.
>
> nick dimiduk wrote:
> For reference, that AMABRI-9993, https://reviews.apache.org/r/33064/
@afernandez - We will move our changes for hbase in params_linux.py to version 1.1.0.2.3.
However,do we ned to remove the condition of checking HDP version > 2.3 also from there?
Our objective is that, these properties should get included only in HDP 2.3 stacks.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/#review80233
-----------------------------------------------------------
On April 15, 2015, 4:13 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33227/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 4:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10503
> https://issues.apache.org/jira/browse/AMBARI-10503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py f971f74
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 7626de8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 2a13337
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 9413d8e
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py e5f9679
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py b3baf32
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ac2bc0a
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py c1f365c
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py abc51d5
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33227/diff/
>
>
> Testing
> -------
>
> Tested with an ambari instance running ranger and a solr server running on one of the node.
> Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 15, 2015, 6:19 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py, line 248
> > <https://reviews.apache.org/r/33227/diff/1/?file=930747#file930747line248>
> >
> > Why don't we branch HBASE into a new version that is used for HDP 2.3? Perhaps sync up with Nick Dimiduk who is also refactoring HBASE and needs to branch it anyways because he's adding a component in HDP 2.3.
> > The practice of checking for "is 2.x or higher" inside HDP 2.2 was a hack that we should not perpetuate.
>
> nick dimiduk wrote:
> For reference, that AMABRI-9993, https://reviews.apache.org/r/33064/
>
> Gautam Borad wrote:
> @afernandez - We will move our changes for hbase in params_linux.py to version 1.1.0.2.3.
> However,do we ned to remove the condition of checking HDP version > 2.3 also from there?
> Our objective is that, these properties should get included only in HDP 2.3 stacks.
For changes that are really HDP 2.3 specific, we should branch the component into HDP 2.3 stack instead of common services. However, your changes seem small enough that we can assume that HBASE 1.1.0.2.3 in common services will be for the HDP 2.3 stack, so we can start cleaning up the old logic of checking stack versions. If you want, you can still add a comment saying that it was introduced in HDP 2.3
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/#review80233
-----------------------------------------------------------
On April 16, 2015, 2:31 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33227/
> -----------------------------------------------------------
>
> (Updated April 16, 2015, 2:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10503
> https://issues.apache.org/jira/browse/AMBARI-10503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py abde3f2
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py 7626de8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 2a13337
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 9413d8e
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py e5f9679
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py b3baf32
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ac2bc0a
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py c1f365c
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py abc51d5
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33227/diff/
>
>
> Testing
> -------
>
> Tested with an ambari instance running ranger and a solr server running on one of the node.
> Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by nick dimiduk <nd...@gmail.com>.
> On April 15, 2015, 11:19 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py, line 248
> > <https://reviews.apache.org/r/33227/diff/1/?file=930747#file930747line248>
> >
> > Why don't we branch HBASE into a new version that is used for HDP 2.3? Perhaps sync up with Nick Dimiduk who is also refactoring HBASE and needs to branch it anyways because he's adding a component in HDP 2.3.
> > The practice of checking for "is 2.x or higher" inside HDP 2.2 was a hack that we should not perpetuate.
For reference, that AMABRI-9993, https://reviews.apache.org/r/33064/
- nick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/#review80233
-----------------------------------------------------------
On April 15, 2015, 9:13 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33227/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 9:13 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10503
> https://issues.apache.org/jira/browse/AMBARI-10503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py f971f74
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 7626de8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 2a13337
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 9413d8e
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py e5f9679
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py b3baf32
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ac2bc0a
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py c1f365c
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py abc51d5
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33227/diff/
>
>
> Testing
> -------
>
> Tested with an ambari instance running ranger and a solr server running on one of the node.
> Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/#review80233
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
<https://reviews.apache.org/r/33227/#comment130029>
Why don't we branch HBASE into a new version that is used for HDP 2.3? Perhaps sync up with Nick Dimiduk who is also refactoring HBASE and needs to branch it anyways because he's adding a component in HDP 2.3.
The practice of checking for "is 2.x or higher" inside HDP 2.2 was a hack that we should not perpetuate.
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
<https://reviews.apache.org/r/33227/#comment130031>
This is only a comment, but has a typo.
- Alejandro Fernandez
On April 15, 2015, 4:13 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33227/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 4:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10503
> https://issues.apache.org/jira/browse/AMBARI-10503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py f971f74
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 7626de8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 2a13337
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 9413d8e
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py e5f9679
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py b3baf32
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ac2bc0a
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py c1f365c
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py abc51d5
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33227/diff/
>
>
> Testing
> -------
>
> Tested with an ambari instance running ranger and a solr server running on one of the node.
> Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/#review81021
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 21, 2015, 11:40 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33227/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 11:40 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10503
> https://issues.apache.org/jira/browse/AMBARI-10503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py efca51a
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py 7626de8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 034d544
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 876e70d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 05d72c8
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 13b0868
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py c989730
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33227/diff/
>
>
> Testing
> -------
>
> Tested with an ambari instance running ranger and a solr server running on one of the node.
> Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/#review80948
-----------------------------------------------------------
Ship it!
we just talked to Guantam offline. We're gonna need to move properties hardcode from python to get rid of check >= 2.3 checks. This is a bigger task, and we'll planing to do it in other ticket(s)
- Andrew Onischuk
On April 21, 2015, 11:40 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33227/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 11:40 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10503
> https://issues.apache.org/jira/browse/AMBARI-10503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py efca51a
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py 7626de8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 034d544
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 876e70d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 05d72c8
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 13b0868
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py c989730
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33227/diff/
>
>
> Testing
> -------
>
> Tested with an ambari instance running ranger and a solr server running on one of the node.
> Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/
-----------------------------------------------------------
(Updated April 21, 2015, 11:40 a.m.)
Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
Changes
-------
Removed stack comparison for hbase in params_linux.py - and attached updated patch.
Bugs: AMBARI-10503
https://issues.apache.org/jira/browse/AMBARI-10503
Repository: ambari
Description
-------
Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py efca51a
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py 7626de8
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 034d544
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 876e70d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 05d72c8
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 13b0868
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py c989730
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
Diff: https://reviews.apache.org/r/33227/diff/
Testing
-------
Tested with an ambari instance running ranger and a solr server running on one of the node.
Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
Thanks,
Gautam Borad
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On April 17, 2015, 10:11 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py, line 251
> > <https://reviews.apache.org/r/33227/diff/2/?file=931738#file931738line251>
> >
> > HDP stack specific logic in common-services is not ideal if we want to make this a common-service for different vendors. At the very least we should check the stack name along with stack version.
We might want not to hardcode properties in Python, but to move them to site.xml and use stack inheritance logic here to have different sets of properties in different stacks.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/#review80545
-----------------------------------------------------------
On April 16, 2015, 2:31 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33227/
> -----------------------------------------------------------
>
> (Updated April 16, 2015, 2:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10503
> https://issues.apache.org/jira/browse/AMBARI-10503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py abde3f2
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py 7626de8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 2a13337
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 9413d8e
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py e5f9679
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py b3baf32
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ac2bc0a
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py c1f365c
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py abc51d5
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33227/diff/
>
>
> Testing
> -------
>
> Tested with an ambari instance running ranger and a solr server running on one of the node.
> Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by Gautam Borad <gb...@gmail.com>.
> On April 17, 2015, 10:11 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py, line 251
> > <https://reviews.apache.org/r/33227/diff/2/?file=931738#file931738line251>
> >
> > HDP stack specific logic in common-services is not ideal if we want to make this a common-service for different vendors. At the very least we should check the stack name along with stack version.
>
> Andrew Onischuk wrote:
> We might want not to hardcode properties in Python, but to move them to site.xml and use stack inheritance logic here to have different sets of properties in different stacks.
As discussed with Andrew, this will be taken up as another task.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/#review80545
-----------------------------------------------------------
On April 21, 2015, 11:40 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33227/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 11:40 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10503
> https://issues.apache.org/jira/browse/AMBARI-10503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py efca51a
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py 7626de8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 034d544
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 876e70d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 05d72c8
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 13b0868
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py c989730
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33227/diff/
>
>
> Testing
> -------
>
> Tested with an ambari instance running ranger and a solr server running on one of the node.
> Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/#review80545
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py
<https://reviews.apache.org/r/33227/#comment130554>
HDP stack specific logic in common-services is not ideal if we want to make this a common-service for different vendors. At the very least we should check the stack name along with stack version.
- Jayush Luniya
On April 16, 2015, 2:31 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33227/
> -----------------------------------------------------------
>
> (Updated April 16, 2015, 2:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10503
> https://issues.apache.org/jira/browse/AMBARI-10503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py abde3f2
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py 7626de8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 2a13337
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 9413d8e
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py e5f9679
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py b3baf32
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ac2bc0a
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py c1f365c
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py abc51d5
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33227/diff/
>
>
> Testing
> -------
>
> Tested with an ambari instance running ranger and a solr server running on one of the node.
> Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 33227: AMBARI-10503 : Ambari-Ranger Stack changes
to add Solr audit db support
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33227/
-----------------------------------------------------------
(Updated April 16, 2015, 2:31 p.m.)
Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
Changes
-------
As per comments - moved hbase changes to latest version and took care of typo in comment.
Bugs: AMBARI-10503
https://issues.apache.org/jira/browse/AMBARI-10503
Repository: ambari
Description
-------
Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit logs.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py abde3f2
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py 7626de8
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 2a13337
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 9413d8e
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py e5f9679
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 54de4a6
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py b3baf32
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c069fc5
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ac2bc0a
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py c1f365c
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py abc51d5
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py a3cc587
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml PRE-CREATION
Diff: https://reviews.apache.org/r/33227/diff/
Testing
-------
Tested with an ambari instance running ranger and a solr server running on one of the node.
Checked the audit logs and they were getting generated for the plugins. ( tested hdfs/hive/hbase/knox )
Thanks,
Gautam Borad