You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "elguardian (via GitHub)" <gi...@apache.org> on 2024/06/07 08:27:23 UTC
[PR] [incubator-kie-issues-1309] Multiinstance loop [incubator-kie-kogito-runtimes]
elguardian opened a new pull request, #3554:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3554
Closes: https://github.com/apache/incubator-kie-issues/issues/1309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1309] Multiinstance loop [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3554:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3554#issuecomment-2237492844
**PR job** `#2` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3554 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3554/2/display/redirect
**Test results:**
- PASSED: 3271
- FAILED: 2
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3554/2/testReport/org.jbpm.bpmn2/FlowTest/testMultiInstanceLoopCharacteristicsTask/">org.jbpm.bpmn2.FlowTest.testMultiInstanceLoopCharacteristicsTask</a></summary>
Build Errors:<br/>Error Messages:<br/>Message [id=1, kieBase=defaultKieBase, level=ERROR, path=BPMN2-MultiInstanceLoopCharacteristicsTask.bpmn2, line=-1, column=0<br/> text=Unable to load process. : Exception class java.io.FileNotFoundException : 'BPMN2-MultiInstanceLoopCharacteristicsTask.bpmn2' cannot be opened because it does not exist]<br/>---<br/>Warning Messages:<br/>---<br/>Info Messages:<br/>
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3554/2/testReport/org.jbpm.bpmn2/IntermediateEventTest/testMultiInstanceLoopBoundaryTimer/">org.jbpm.bpmn2.IntermediateEventTest.testMultiInstanceLoopBoundaryTimer</a></summary>
<br/>expected: 2<br/> but was: 1
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1309] Multiinstance loop [incubator-kie-kogito-runtimes]
Posted by "pefernan (via GitHub)" <gi...@apache.org>.
pefernan commented on code in PR #3554:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3554#discussion_r1686371559
##########
jbpm/jbpm-flow/src/main/java/org/jbpm/workflow/instance/node/ForEachNodeInstance.java:
##########
@@ -319,21 +317,13 @@ private boolean areNodeInstancesCompleted() {
return getNodeInstanceContainer().getNodeInstances().size() == 1;
}
- private boolean evaluateCompletionCondition(String expression, Map<String, Object> tempVariables) {
- if (expression == null || expression.isEmpty()) {
- return false;
- } else {
- try {
- Object result = MVELProcessHelper.evaluator().eval(expression,
- new ForEachNodeInstanceResolverFactory(this, tempVariables));
- if (!(result instanceof Boolean)) {
- throw new IllegalArgumentException("Completion condition expression must return boolean values: " +
- result + " for expression " + expression);
- }
- return ((Boolean) result).booleanValue();
- } catch (Exception t) {
- throw new IllegalArgumentException("Could not evaluate completion condition " + expression, t);
- }
+ private boolean evaluateCompletionCondition(ReturnValueEvaluator completeConditionEvaluator, Map<String, Object> tempVariables) {
+ try {
+ KogitoProcessContextImpl context = (KogitoProcessContextImpl) ContextFactory.fromNode(this);
Review Comment:
Cast not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1309] Multiinstance loop [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3554:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3554#issuecomment-2255743856
**PR job** `#5` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3554 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3554/5/display/redirect
**Test results:**
- PASSED: 3286
- FAILED: 1
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3554/5/testReport/org.kie.kogito.quarkus.workflows/PojoServiceIT/testPojo/">org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojo</a></summary>
<br/>Expected size: 1 but was: 2 in:<br/>{"age"=666, "name"="javieritoPerson"}
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1309] Multiinstance loop [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian merged PR #3554:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org