You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (Updated) (JIRA)" <ji...@apache.org> on 2011/12/15 04:21:30 UTC

[jira] [Updated] (SOLR-2971) ExternalFileFields fail if valType='float', and valType should be optional

     [ https://issues.apache.org/jira/browse/SOLR-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Erickson updated SOLR-2971:
---------------------------------

    Attachment: SOLR-2971.patch

Patch for trunk. I haven't run full regression tests against it yet, but I think it's pretty solid.

I'll commit in a day or two unless there are objections...
                
> ExternalFileFields fail if valType='float', and valType should be optional
> --------------------------------------------------------------------------
>
>                 Key: SOLR-2971
>                 URL: https://issues.apache.org/jira/browse/SOLR-2971
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>    Affects Versions: 3.5, 4.0
>         Environment: all
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2971.patch
>
>
> valType has never done anything except throw an error, the underlying ValueSource has always been a FileFloatSource. To add to the confusion, the documents say use "float", which throws an exception on Solr startup every since "float" was re-defined as a TrieFloatField. "pfloat" works currently though.
> Since valType is never used for anything, we should make it optional until such a time as it is.
> Additionally, TrieFloatField (valtype="float|tfloat") types should be OK as a field type along with FloatField(valType="pfloat")

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org