You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by DaanHoogland <gi...@git.apache.org> on 2015/03/25 21:55:39 UTC
[GitHub] cloudstack pull request: findbugs: Boolen function should not retu...
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/131
findbugs: Boolen function should not return null
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack hotfix/findbugs-unknownvm-as-null
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #131
----
commit 048212b1176158c379fcb9c9a9c9d51784c406e2
Author: Daan Hoogland <dh...@schubergphilis.com>
Date: 2015-03-25T20:46:47Z
findbugs: Boolen function should not return null
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: Boolen function should not retu...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/131#issuecomment-86221078
will add that change as well (why not try?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: Boolen function should not retu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: Boolen function should not retu...
Posted by K0zka <gi...@git.apache.org>.
Github user K0zka commented on the pull request:
https://github.com/apache/cloudstack/pull/131#issuecomment-86220564
I agree with the change (not tested yet)
Once it does not return null, the Boolean could be boolean?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---