You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/12 01:04:06 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
dongjoon-hyun opened a new pull request #35174:
URL: https://github.com/apache/spark/pull/35174
### What changes were proposed in this pull request?
This PR aims to introduce `precondition` jobs to skip the main GitHub Action jobs.
### Why are the changes needed?
This will save huge community GitHub Action resource and speed up our develop and PR review process.
- For example, GitHub Action will run only `linter` job for `docs` only PR.
<img width="468" alt="Screen Shot 2022-01-07 at 12 10 50 AM" src="https://user-images.githubusercontent.com/9700541/148512753-bd9b7e49-0e7b-47dd-9ce5-31f684dac666.png">
### Does this PR introduce _any_ user-facing change?
No. This is a dev-only infra.
### How was this patch tested?
Manually review and check the result on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35174:
URL: https://github.com/apache/spark/pull/35174#discussion_r782637801
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -242,15 +275,16 @@ jobs:
name: unit-tests-log-${{ matrix.modules }}-${{ matrix.comment }}-${{ matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
path: "**/target/unit-tests.log"
+
Review comment:
nit ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35174:
URL: https://github.com/apache/spark/pull/35174#issuecomment-1010621266
Thank you, @HyukjinKwon . Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35174:
URL: https://github.com/apache/spark/pull/35174#discussion_r782637698
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -242,15 +275,16 @@ jobs:
name: unit-tests-log-${{ matrix.modules }}-${{ matrix.comment }}-${{ matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
path: "**/target/unit-tests.log"
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35174:
URL: https://github.com/apache/spark/pull/35174#issuecomment-1010525403
Hi, @HyukjinKwon . This is the second try of `precondition` and the following is added.
```
env:
GITHUB_PREV_SHA: ${{ github.event.before }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35174:
URL: https://github.com/apache/spark/pull/35174#issuecomment-1010530012
I hope everything goes well this time. 🤞🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35174:
URL: https://github.com/apache/spark/pull/35174#discussion_r782638255
##########
File path: dev/is-changed.py
##########
@@ -57,9 +57,15 @@ def main():
changed_files = identify_changed_files_from_git_commits(
"HEAD", target_ref=os.environ["APACHE_SPARK_REF"]
)
- changed_modules = determine_modules_to_test(
- determine_modules_for_files(changed_files), deduplicated=False
- )
+ if os.environ.get("APACHE_SPARK_REF", "") != "":
Review comment:
Maybe we can just do:
```suggestion
if os.environ.get("APACHE_SPARK_REF"):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35174:
URL: https://github.com/apache/spark/pull/35174#issuecomment-1010527704
Oops. I missed your comment about `is-changed.py`. I updated `is-changed.py` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35174:
URL: https://github.com/apache/spark/pull/35174#discussion_r782638397
##########
File path: dev/is-changed.py
##########
@@ -57,9 +57,15 @@ def main():
changed_files = identify_changed_files_from_git_commits(
"HEAD", target_ref=os.environ["APACHE_SPARK_REF"]
)
- changed_modules = determine_modules_to_test(
- determine_modules_for_files(changed_files), deduplicated=False
- )
+ if os.environ.get("APACHE_SPARK_REF", "") != "":
Review comment:
or `"APACHE_SPARK_REF" in os.environ`
##########
File path: dev/is-changed.py
##########
@@ -57,9 +57,15 @@ def main():
changed_files = identify_changed_files_from_git_commits(
"HEAD", target_ref=os.environ["APACHE_SPARK_REF"]
)
- changed_modules = determine_modules_to_test(
- determine_modules_for_files(changed_files), deduplicated=False
- )
+ if os.environ.get("APACHE_SPARK_REF", "") != "":
+ changed_modules = determine_modules_to_test(
+ determine_modules_for_files(changed_files), deduplicated=False
+ )
+ elif os.environ.get("GITHUB_PREV_SHA", "") != "":
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35174:
URL: https://github.com/apache/spark/pull/35174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35174:
URL: https://github.com/apache/spark/pull/35174#discussion_r782638596
##########
File path: dev/is-changed.py
##########
@@ -57,9 +57,15 @@ def main():
changed_files = identify_changed_files_from_git_commits(
"HEAD", target_ref=os.environ["APACHE_SPARK_REF"]
)
- changed_modules = determine_modules_to_test(
- determine_modules_for_files(changed_files), deduplicated=False
- )
+ if os.environ.get("APACHE_SPARK_REF", "") != "":
Review comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35174: [SPARK-37833][INFRA] Add `precondition` job to skip the main GitHub Action jobs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35174:
URL: https://github.com/apache/spark/pull/35174#discussion_r782636361
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -96,15 +96,48 @@ jobs:
echo '::set-output name=hadoop::hadoop3'
fi
+ precondition:
+ name: Check changes
+ runs-on: ubuntu-20.04
+ env:
+ GITHUB_PREV_SHA: ${{ github.event.before }}
Review comment:
This is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org