You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "bbejeck (via GitHub)" <gi...@apache.org> on 2025/12/10 20:39:26 UTC
[PR] KAFKA-19959: Update session and window store with new default when no open iterators [kafka]
bbejeck opened a new pull request, #21120:
URL: https://github.com/apache/kafka/pull/21120
When applying the NPE fix for the `oldest-iterator-open-since-ms` metric we only applied this to the `MeteredKeyValueStore`. This fix needs to be applied to `MeteredSessionStore` and `MeteredWindowStore` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19959: Update session and window store with new default when no open iterators [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #21120:
URL: https://github.com/apache/kafka/pull/21120#issuecomment-3643906670
Merged #21120 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19959: Update session and window store with new default when no open iterators [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #21120:
URL: https://github.com/apache/kafka/pull/21120#issuecomment-3643941107
cherry-picked to 4.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19959: Update session and window store with new default when no open iterators [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck merged PR #21120:
URL: https://github.com/apache/kafka/pull/21120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19959: Update session and window store with new default when no open iterators [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on code in PR #21120:
URL: https://github.com/apache/kafka/pull/21120#discussion_r2608145560
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStoreTest.java:
##########
@@ -530,6 +530,8 @@ public void shouldTrackOldestOpenIteratorTimestamp() {
final KafkaMetric oldestIteratorTimestampMetric = metric("oldest-iterator-open-since-ms");
assertThat(oldestIteratorTimestampMetric, not(nullValue()));
+ assertThat(oldestIteratorTimestampMetric.metricValue(), equalTo(0L));
Review Comment:
Added this to validate the `KafkaMetric.value()` returns `0L` the window and session tests had this line so I put here to be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19959: Update session and window store with new default when no open iterators [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #21120:
URL: https://github.com/apache/kafka/pull/21120#issuecomment-3643960758
cherry-picked to 4.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19959: Update session and window store with new default when no open iterators [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on code in PR #21120:
URL: https://github.com/apache/kafka/pull/21120#discussion_r2608149296
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredSessionStoreTest.java:
##########
@@ -733,14 +733,14 @@ public void shouldTrackOldestOpenIteratorTimestamp() {
}
// now that the first iterator is closed, check that the timestamp has advanced to the still open second iterator
- assertThat((Long) oldestIteratorTimestampMetric.metricValue(), equalTo(secondTimestamp));
+ assertThat(oldestIteratorTimestampMetric.metricValue(), equalTo(secondTimestamp));
} finally {
if (second != null) {
second.close();
}
}
- assertThat((Integer) oldestIteratorTimestampMetric.metricValue(), nullValue());
+ assertThat(oldestIteratorTimestampMetric.metricValue(), equalTo(0L));
}
Review Comment:
Same here
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredWindowStoreTest.java:
##########
@@ -517,14 +517,14 @@ public void shouldTrackOldestOpenIteratorTimestamp() {
}
// now that the first iterator is closed, check that the timestamp has advanced to the still open second iterator
- assertThat((Long) oldestIteratorTimestampMetric.metricValue(), equalTo(secondTimestamp));
+ assertThat(oldestIteratorTimestampMetric.metricValue(), equalTo(secondTimestamp));
} finally {
if (second != null) {
second.close();
}
}
- assertThat((Integer) oldestIteratorTimestampMetric.metricValue(), nullValue());
+ assertThat(oldestIteratorTimestampMetric.metricValue(), equalTo(0L));
}
Review Comment:
Again removed unnecessary cast
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStoreTest.java:
##########
@@ -546,14 +548,14 @@ public void shouldTrackOldestOpenIteratorTimestamp() {
}
// now that the first iterator is closed, check that the timestamp has advanced to the still open second iterator
- assertThat((Long) oldestIteratorTimestampMetric.metricValue(), equalTo(secondTimestamp));
+ assertThat(oldestIteratorTimestampMetric.metricValue(), equalTo(secondTimestamp));
} finally {
if (second != null) {
second.close();
}
}
// no open iterators left, timestamp should be reset to 0
- assertThat((Long) oldestIteratorTimestampMetric.metricValue(), equalTo(0L));
+ assertThat(oldestIteratorTimestampMetric.metricValue(), equalTo(0L));
Review Comment:
Removed cast to `Long` here and above, not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org