[jira] [Commented] (PROTON-715) [contrib/proton-jms] delivery-count is set incorrectly during Native outbound transformation

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172472#comment-14172472 ] 

ASF subversion and git services commented on PROTON-715:
--------------------------------------------------------

Commit 1632091 from [~gemmellr] in branch 'proton/trunk'
[ https://svn.apache.org/r1632091 ]

PROTON-715: subtract 1 when setting delivery-count header based on JMSXDeliveryCount during outbound Native transformation

> [contrib/proton-jms] delivery-count is set incorrectly during Native outbound transformation
> --------------------------------------------------------------------------------------------
>
>                 Key: PROTON-715
>                 URL: https://issues.apache.org/jira/browse/PROTON-715
>             Project: Qpid Proton
>          Issue Type: Bug
>    Affects Versions: 0.7
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.8
>
>
> In the proton-jms contrib artifact, delivery-count is set incorrectly (based on JMSXDeliveryCount) during outbound 'Native' message transformation.
> The value set is the same as the JMSXDeliveryCount value encountered, which is incorrect as the two have different semantics. The delivery-count field in the AMQP 1.0 message header tracks prior unsuccessful delivery attempts and so should go 0,1,2 etc if set. JMSXDeliveryCount property in JMS tracks the total number of delivery attempts, and should go 1,2,3. As such, delivery-count should be 1 less than JMSXDeliveryCount, not equal to it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)