[GitHub] [camel-k] squakez commented on a diff in pull request #4190: add startup probes into the health trait

["squakez (via GitHub)" <gi...@apache.org>]

squakez commented on code in PR #4190:
URL: https://github.com/apache/camel-k/pull/4190#discussion_r1152963974


##########
e2e/common/traits/health_test.go:
##########
@@ -328,5 +328,57 @@ func TestHealthTrait(t *testing.T) {
 			}))
 	})
 
+	t.Run("Startup condition with never properly started route", func(t *testing.T) {
+		name := "startup-never-ready"
+
+		Expect(KamelRunWithID(operatorID, ns, "files/NeverReady.java",
+			"-t", "health.enabled=true",

Review Comment:
   I think this test is missing the equivalent of running the new probe with `-t health.startup-probe-enabled=true`



##########
pkg/trait/health.go:
##########
@@ -97,6 +99,9 @@ func (t *healthTrait) Apply(e *Environment) error {
 	if pointer.BoolDeref(t.ReadinessProbeEnabled, true) {
 		container.ReadinessProbe = t.newReadinessProbe(port, defaultReadinessProbePath)
 	}
+	if pointer.BoolDeref(t.StartupProbeEnabled, true) {

Review Comment:
   We said the default should be false, so we need to adjust the value here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org