You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/25 00:27:20 UTC
[jira] [Commented] (TINKERPOP-944) Deprecate
Graph.Exceptions.elementNotFound
[ https://issues.apache.org/jira/browse/TINKERPOP-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15519861#comment-15519861 ]
ASF GitHub Bot commented on TINKERPOP-944:
------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/436
TINKERPOP-944 Deprecate Graph.Exceptions.elementNotFound()
https://issues.apache.org/jira/browse/TINKERPOP-944
This exception wasn't used in the code base at all except for tests. Seems best to just deprecate (in case a graph provider is publically using it). Didn't change the nature of the tests that were using this method, so this should be a non-breaking change.
The change is pretty simple, but I decided not to CTR since "deprecation" was involved. All tests good with `mvn clean install`.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-944
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/436.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #436
----
commit 83a4cf109d840a929b5cabcf1db584cc75378bc1
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-25T00:23:59Z
Deprecate Graph.Exceptions.elementNotFound()
This exception wasn't used in the code base at all except for tests. Seems best to just deprecate (in case a graph provider is publically using it). Didn't change the nature of the tests that were using this method, so this should be a non-breaking change.
----
> Deprecate Graph.Exceptions.elementNotFound
> ------------------------------------------
>
> Key: TINKERPOP-944
> URL: https://issues.apache.org/jira/browse/TINKERPOP-944
> Project: TinkerPop
> Issue Type: Improvement
> Components: structure
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.2.3
>
>
> As it sits right now, the standard {{elementNotFound}} exception is not used in the core code base, but we are validating that it is being thrown in the test suite by providers! The test is actually faulty because it is not asserting the message and just that it is a {{NoSuchElementException}} which is causing the problem. We should either deprecate this method and just validate {{NoSuchElementException}} or use it in full and force providers to do the same.
> This has the potential to be a breaking change as it might break tests if providers aren't using that standard exception.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)