You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/06 14:41:18 UTC

[GitHub] [pulsar] freeznet opened a new issue, #15667: `topicName` should not be a `required` config for source connector

freeznet opened a new issue, #15667:
URL: https://github.com/apache/pulsar/issues/15667

   **Describe the bug**
   For some of the source connectors, like debezium connector, it actually not sending any messages to the `topicName`. And the `topicName` cannot be null: https://github.com/apache/pulsar/blob/branch-2.10/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfigUtils.java#L296-L298
   
   But from the java instance, if no topic is provided, it will use [PulsarSinkDisable](https://github.com/apache/pulsar/blob/branch-2.10/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSinkDisable.java) instead. 
   
   We should remove the strict validation on `topicName` for the source connector.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Go to '...'
   2. Click on '....'
   3. Scroll down to '....'
   4. See error
   
   **Expected behavior**
   A clear and concise description of what you expected to happen.
   
   **Screenshots**
   If applicable, add screenshots to help explain your problem.
   
   **Desktop (please complete the following information):**
    - OS: [e.g. iOS]
   
   **Additional context**
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun closed issue #15667: `topicName` should not be a `required` config for source connector

Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #15667: `topicName` should not be a `required` config for source connector
URL: https://github.com/apache/pulsar/issues/15667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #15667: `topicName` should not be a `required` config for source connector

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #15667:
URL: https://github.com/apache/pulsar/issues/15667#issuecomment-1339488482

   I get the point now. Coming up with a patch soon..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on issue #15667: `topicName` should not be a `required` config for source connector

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15667:
URL: https://github.com/apache/pulsar/issues/15667#issuecomment-1207575833

   The issue had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on issue #15667: `topicName` should not be a `required` config for source connector

Posted by GitBox <gi...@apache.org>.
momo-jun commented on issue #15667:
URL: https://github.com/apache/pulsar/issues/15667#issuecomment-1178645114

   @freeznet I'm adding the information for this issue. Can you pls address the involved versions that the issue applies to?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun closed issue #15667: `topicName` should not be a `required` config for source connector

Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #15667: `topicName` should not be a `required` config for source connector
URL: https://github.com/apache/pulsar/issues/15667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on issue #15667: `topicName` should not be a `required` config for source connector

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15667:
URL: https://github.com/apache/pulsar/issues/15667#issuecomment-1159601530

   The issue had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #15667: `topicName` should not be a `required` config for source connector

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #15667:
URL: https://github.com/apache/pulsar/issues/15667#issuecomment-1339482488

   Closed as stale and no one worked on it. Please open a new issue if it's still relevant to the maintained versions.
   
   For this issue, it seems you can directly submit a patch to remove the validation.
   
   I cannot read the description that you talk about the source config but refer to [PulsarSinkDisable](https://github.com/apache/pulsar/blob/branch-2.10/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSinkDisable.java). Perhaps more concrete context helps contributors to continue it.
   
   Feel free to reopen with additional context.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org