[GitHub] [spark] keerthanvasist commented on a change in pull request #32771: [Python][Bug] Fix ambiguous reference in functions.py column()

[GitBox <gi...@apache.org>]

keerthanvasist commented on a change in pull request #32771:
URL: https://github.com/apache/spark/pull/32771#discussion_r645275989



##########
File path: python/pyspark/sql/functions.py
##########
@@ -101,19 +101,19 @@ def lit(col):
 
 
 @since(1.3)
-def col(col):
+def col(col_like):

Review comment:
       Don't you think `col_like` is a better name? It could be column name as a string or a Column object - I see a comment at the beginning of the file. Besides, it will avoid another ambiguous event like this. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org