You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2026/09/02 04:23:00 UTC
[PR] refactor: tighten KLL API and query performance (datasketches-rust)
tisonkun opened a new pull request, #263:
URL: https://github.com/apache/datasketches-rust/pull/263
## Summary
- rename the generic KLL helper module around its capacity responsibility and minimize internal/public visibility
- replace the combined item trait with explicit `KllComparator` and serialization-only `KllValue` contracts
- align KLL queries with REQ through shared `SearchCriteria`, fallible validation, batch quantiles, and an owned reusable `SortedView`
- reject incompatible merges before mutation and check combined stream-weight overflow
- cache retained/capacity state, compute ranks without constructing a sorted view, merge already-sorted levels when building views, and streamline compaction
- split KLL integration tests by behavior, replace stochastic assertions with deterministic invariants, enable Go compatibility fixtures, and test a custom `KllValue`
- add KLL update, query, merge, and serialization benchmarks
## Validation
- `cargo x check`
- `cargo x test`
- `cargo x lint`
- `cargo bench -p benchmarks --no-run`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] refactor: tighten KLL API and query performance (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #263:
URL: https://github.com/apache/datasketches-rust/pull/263#discussion_r3911761358
##########
CHANGELOG.md:
##########
@@ -4,13 +4,18 @@ All significant changes to this project will be documented in this file.
## Unreleased
+### Breaking changes
+
+* Move `SearchCriteria` from `req` to `common` and remove its `Default` implementation. Import `datasketches::common::SearchCriteria` and explicitly choose `Inclusive` or `Exclusive` for each query.
+
### New features
-* Add KLL sketches behind the `kll` feature, including rank, quantile, PMF, and CDF queries, custom item ordering, merging, and C++/Java-compatible serialization.
+* Add KLL sketches behind the `kll` feature, with rank, quantile, PMF, and CDF queries, merging, totally ordered custom item types, a `KllFloat` adapter for non-NaN floating-point values, and serialization.
-### Bug fixes
+### Improvements
-* T-Digest deserialization now rejects unknown or conflicting flags, reversed extrema, out-of-range values, unsorted centroids, and non-empty images without stored values.
+* Improve KLL update and query performance.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] refactor: tighten KLL API and query performance (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #263:
URL: https://github.com/apache/datasketches-rust/pull/263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org