You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by ss...@apache.org on 2013/07/06 01:00:04 UTC
svn commit: r1500160 - in /mahout/trunk: buildtools/pom.xml
buildtools/src/main/resources/mahout-checkstyle.xml
buildtools/src/main/resources/mahout-pmd-ruleset.xml pom.xml
Author: sslavic
Date: Fri Jul 5 23:00:04 2013
New Revision: 1500160
URL: http://svn.apache.org/r1500160
Log:
Properly configured sharing build resources (checkstyle, findbugs, pmd custom settings) across multiple modules of the project
Modified:
mahout/trunk/buildtools/pom.xml
mahout/trunk/buildtools/src/main/resources/mahout-checkstyle.xml
mahout/trunk/buildtools/src/main/resources/mahout-pmd-ruleset.xml
mahout/trunk/pom.xml
Modified: mahout/trunk/buildtools/pom.xml
URL: http://svn.apache.org/viewvc/mahout/trunk/buildtools/pom.xml?rev=1500160&r1=1500159&r2=1500160&view=diff
==============================================================================
--- mahout/trunk/buildtools/pom.xml (original)
+++ mahout/trunk/buildtools/pom.xml Fri Jul 5 23:00:04 2013
@@ -20,18 +20,17 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
- <parent>
- <groupId>org.apache.mahout</groupId>
- <artifactId>mahout</artifactId>
- <version>0.8-SNAPSHOT</version>
- <relativePath>../pom.xml</relativePath>
- </parent>
-
+ <groupId>org.apache.mahout</groupId>
<artifactId>mahout-buildtools</artifactId>
+ <version>0.8-SNAPSHOT</version>
<name>Mahout Build Tools</name>
<packaging>jar</packaging>
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ </properties>
+
<profiles>
<profile>
<id>setup-eclipse-workspace</id>
Modified: mahout/trunk/buildtools/src/main/resources/mahout-checkstyle.xml
URL: http://svn.apache.org/viewvc/mahout/trunk/buildtools/src/main/resources/mahout-checkstyle.xml?rev=1500160&r1=1500159&r2=1500160&view=diff
==============================================================================
--- mahout/trunk/buildtools/src/main/resources/mahout-checkstyle.xml (original)
+++ mahout/trunk/buildtools/src/main/resources/mahout-checkstyle.xml Fri Jul 5 23:00:04 2013
@@ -155,7 +155,6 @@
<!-- Checks for common coding problems -->
<!-- See http://checkstyle.sf.net/config_coding.html -->
<!--module name="AvoidInlineConditionals"/-->
- <module name="DoubleCheckedLocking"/>
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<!--module name="HiddenField"/-->
Modified: mahout/trunk/buildtools/src/main/resources/mahout-pmd-ruleset.xml
URL: http://svn.apache.org/viewvc/mahout/trunk/buildtools/src/main/resources/mahout-pmd-ruleset.xml?rev=1500160&r1=1500159&r2=1500160&view=diff
==============================================================================
--- mahout/trunk/buildtools/src/main/resources/mahout-pmd-ruleset.xml (original)
+++ mahout/trunk/buildtools/src/main/resources/mahout-pmd-ruleset.xml Fri Jul 5 23:00:04 2013
@@ -21,169 +21,169 @@
<description>PMD Plugin preferences rule set</description>
- <rule ref="rulesets/basic.xml/BooleanInstantiation"/>
- <rule ref="rulesets/basic.xml/CollapsibleIfStatements"/>
- <rule ref="rulesets/basic.xml/DoubleCheckedLocking"/>
- <!--<rule ref="rulesets/basic.xml/EmptyCatchBlock"/>-->
- <rule ref="rulesets/basic.xml/EmptyFinallyBlock"/>
- <rule ref="rulesets/basic.xml/EmptyIfStmt"/>
- <rule ref="rulesets/basic.xml/EmptyStatementNotInLoop"/>
- <!--<rule ref="rulesets/basic.xml/EmptyStaticInitializer"/>-->
- <!--<rule ref="rulesets/basic.xml/EmptySwitchStatements"/>-->
- <rule ref="rulesets/basic.xml/EmptySynchronizedBlock"/>
- <rule ref="rulesets/basic.xml/EmptyTryBlock"/>
- <!--<rule ref="rulesets/basic.xml/EmptyWhileStmt"/>-->
- <rule ref="rulesets/basic.xml/ForLoopShouldBeWhileLoop"/>
- <rule ref="rulesets/basic.xml/JumbledIncrementer"/>
- <rule ref="rulesets/basic.xml/OverrideBothEqualsAndHashcode"/>
- <rule ref="rulesets/basic.xml/ReturnFromFinallyBlock"/>
- <rule ref="rulesets/basic.xml/UnconditionalIfStatement"/>
- <rule ref="rulesets/basic.xml/UnnecessaryConversionTemporary"/>
- <rule ref="rulesets/basic.xml/UnnecessaryFinalModifier"/>
- <rule ref="rulesets/basic.xml/UnnecessaryReturn"/>
- <!--<rule ref="rulesets/basic.xml/UselessOverridingMethod"/>-->
-
- <!--<rule ref="rulesets/braces.xml/ForLoopsMustUseBraces"/>-->
- <!--<rule ref="rulesets/braces.xml/IfElseStmtsMustUseBraces"/>-->
- <!--<rule ref="rulesets/braces.xml/IfStmtsMustUseBraces"/>-->
- <!--<rule ref="rulesets/braces.xml/WhileLoopsMustUseBraces"/>-->
-
- <!--<rule ref="rulesets/clone.xml/CloneMethodMustImplementCloneable"/>-->
- <!--<rule ref="rulesets/clone.xml/CloneThrowsCloneNotSupportedException"/>-->
- <!--<rule ref="rulesets/clone.xml/ProperCloneImplementation"/>-->
-
- <!--<rule ref="rulesets/codesize.xml/CyclomaticComplexity"/>-->
- <rule ref="rulesets/codesize.xml/ExcessiveClassLength"/>
- <rule ref="rulesets/codesize.xml/ExcessiveMethodLength"/>
- <rule ref="rulesets/codesize.xml/ExcessiveParameterList"/>
- <rule ref="rulesets/codesize.xml/ExcessivePublicCount"/>
- <!--<rule ref="rulesets/codesize.xml/TooManyFields"/>-->
-
- <!--<rule ref="rulesets/controversial.xml/AssignmentInOperand"/>-->
- <!--<rule ref="rulesets/controversial.xml/AtLeastOneConstructor"/>-->
- <!--<rule ref="rulesets/controversial.xml/CallSuperInConstructor"/>-->
- <!--<rule ref="rulesets/controversial.xml/DontImportSun"/>-->
- <!--<rule ref="rulesets/controversial.xml/NullAssignment"/>-->
- <!--<rule ref="rulesets/controversial.xml/OnlyOneReturn"/>-->
- <!--<rule ref="rulesets/controversial.xml/SingularField"/>-->
- <!--<rule ref="rulesets/controversial.xml/SuspiciousOctalEscape"/>-->
- <!--<rule ref="rulesets/controversial.xml/UnnecessaryConstructor"/>-->
- <!--<rule ref="rulesets/controversial.xml/UnnecessaryParentheses"/>-->
- <!--<rule ref="rulesets/controversial.xml/UnusedModifier"/>-->
-
- <!--<rule ref="rulesets/coupling.xml/CouplingBetweenObjects"/>-->
- <!--<rule ref="rulesets/coupling.xml/ExcessiveImports"/>-->
- <!--<rule ref="rulesets/coupling.xml/LooseCoupling"/>-->
-
- <!--<rule ref="rulesets/design.xml/AbstractClassWithoutAbstractMethod"/>-->
- <!--<rule ref="rulesets/design.xml/AccessorClassGeneration"/>-->
- <!--<rule ref="rulesets/design.xml/AssignmentToNonFinalStatic"/>-->
- <!--<rule ref="rulesets/design.xml/AvoidDeeplyNestedIfStmts"/>-->
- <!--<rule ref="rulesets/design.xml/AvoidInstanceofChecksInCatchClause"/>-->
- <rule ref="rulesets/design.xml/AvoidProtectedFieldInFinalClass"/>
- <!--<rule ref="rulesets/design.xml/AvoidReassigningParameters"/>-->
- <!--<rule ref="rulesets/design.xml/AvoidSynchronizedAtMethodLevel"/>-->
- <!--<rule ref="rulesets/design.xml/BadComparison"/>-->
- <!--<rule ref="rulesets/design.xml/CloseConnection"/>-->
- <!--<rule ref="rulesets/design.xml/CompareObjectsWithEquals"/>-->
- <!--<rule ref="rulesets/design.xml/ConfusingTernary"/>-->
- <rule ref="rulesets/design.xml/ConstructorCallsOverridableMethod"/>
- <!--<rule ref="rulesets/design.xml/DefaultLabelNotLastInSwitchStmt"/>-->
- <!--<rule ref="rulesets/design.xml/FinalFieldCouldBeStatic"/>-->
- <rule ref="rulesets/design.xml/IdempotentOperations"/>
- <!--<rule ref="rulesets/design.xml/ImmutableField"/>-->
- <!--<rule ref="rulesets/design.xml/InstantiationToGetClass"/>-->
- <!--<rule ref="rulesets/design.xml/MissingBreakInSwitch"/>-->
- <!--<rule ref="rulesets/design.xml/MissingStaticMethodInNonInstantiatableClass"/>-->
- <!--<rule ref="rulesets/design.xml/NonCaseLabelInSwitchStatement"/>-->
- <!--<rule ref="rulesets/design.xml/NonStaticInitializer"/>-->
- <rule ref="rulesets/design.xml/OptimizableToArrayCall"/>
- <rule ref="rulesets/design.xml/PositionLiteralsFirstInComparisons"/>
- <!--rule ref="rulesets/design.xml/SimplifyBooleanExpressions"/-->
- <rule ref="rulesets/design.xml/SimplifyBooleanReturns"/>
- <rule ref="rulesets/design.xml/SimplifyConditional"/>
- <!--<rule ref="rulesets/design.xml/SwitchDensity"/>-->
- <!--<rule ref="rulesets/design.xml/SwitchStmtsShouldHaveDefault"/>-->
- <rule ref="rulesets/design.xml/UnnecessaryLocalBeforeReturn"/>
- <!--<rule ref="rulesets/design.xml/UseLocaleWithCaseConversions"/>-->
- <!--<rule ref="rulesets/design.xml/UseNotifyAllInsteadOfNotify"/>-->
- <!--<rule ref="rulesets/design.xml/UseSingleton"/>-->
-
- <!--<rule ref="rulesets/finalizers.xml/EmptyFinalizer"/>-->
- <!--<rule ref="rulesets/finalizers.xml/FinalizeOnlyCallsSuperFinalize"/>-->
- <!--<rule ref="rulesets/finalizers.xml/FinalizeOverloaded"/>-->
- <!--<rule ref="rulesets/finalizers.xml/FinalizeDoesNotCallSuperFinalize"/>-->
- <!--<rule ref="rulesets/finalizers.xml/FinalizeShouldBeProtected"/>-->
- <rule ref="rulesets/finalizers.xml/AvoidCallingFinalize"/>
-
- <rule ref="rulesets/imports.xml/DuplicateImports"/>
- <rule ref="rulesets/imports.xml/DontImportJavaLang"/>
- <rule ref="rulesets/imports.xml/UnusedImports"/>
- <rule ref="rulesets/imports.xml/ImportFromSamePackage"/>
-
- <!--<rule ref="rulesets/javabeans.xml/BeanMembersShouldSerialize"/>-->
- <!--<rule ref="rulesets/javabeans.xml/MissingSerialVersionUID"/>-->
-
- <!--<rule ref="rulesets/junit.xml/JUnitStaticSuite"/>-->
- <!--<rule ref="rulesets/junit.xml/JUnitSpelling"/>-->
- <!--<rule ref="rulesets/junit.xml/JUnitAssertionsShouldIncludeMessage"/>-->
- <!--<rule ref="rulesets/junit.xml/JUnitTestsShouldIncludeAssert"/>-->
- <!--<rule ref="rulesets/junit.xml/TestClassWithoutTestCases"/>-->
- <!--<rule ref="rulesets/junit.xml/UnnecessaryBooleanAssertion"/>-->
- <!--<rule ref="rulesets/junit.xml/UseAssertEqualsInsteadOfAssertTrue"/>-->
- <!--<rule ref="rulesets/junit.xml/UseAssertSameInsteadOfAssertTrue"/>-->
-
- <rule ref="rulesets/logging-java.xml/AvoidPrintStackTrace"/>
- <rule ref="rulesets/logging-java.xml/LoggerIsNotStaticFinal"/>
- <!--<rule ref="rulesets/logging-java.xml/MoreThanOneLogger"/>-->
- <!--<rule ref="rulesets/logging-java.xml/LoggerIsNotStaticFinal"/>-->
- <!--<rule ref="rulesets/logging-java.xml/LogBlockWithoutIf"/>-->
- <!--<rule ref="rulesets/logging-java.xml/SystemPrintln"/>-->
- <!--<rule ref="rulesets/logging-jakarta-commons.xml/UseCorrectExceptionLogging"/>-->
- <!--<rule ref="rulesets/logging-jakarta-commons.xml/ProperLogger"/>-->
-
- <!--<rule ref="rulesets/naming.xml/ShortVariable"/>-->
- <!--<rule ref="rulesets/naming.xml/LongVariable"/>-->
- <!--<rule ref="rulesets/naming.xml/ShortMethodName"/>-->
- <!--<rule ref="rulesets/naming.xml/VariableNamingConventions"/>-->
- <rule ref="rulesets/naming.xml/MethodNamingConventions"/>
- <rule ref="rulesets/naming.xml/ClassNamingConventions"/>
- <!--<rule ref="rulesets/naming.xml/AbstractNaming"/>-->
- <!--<rule ref="rulesets/naming.xml/AvoidDollarSigns"/>-->
- <!--<rule ref="rulesets/naming.xml/MethodWithSameNameAsEnclosingClass"/>-->
- <!--<rule ref="rulesets/naming.xml/SuspiciousHashcodeMethodName"/>-->
- <!--<rule ref="rulesets/naming.xml/SuspiciousConstantFieldName"/>-->
- <!--<rule ref="rulesets/naming.xml/AvoidFieldNameMatchingTypeName"/>-->
- <!--<rule ref="rulesets/naming.xml/AvoidFieldNameMatchingMethodName"/>-->
- <!-- <rule ref="rulesets/naming.xml/AvoidNonConstructorMethodsWithClassName"/> -->
- <rule ref="rulesets/naming.xml/NoPackage"/>
- <rule ref="rulesets/naming.xml/PackageCase"/>
-
- <!--<rule ref="rulesets/optimizations.xml/LocalVariableCouldBeFinal"/>-->
- <!--<rule ref="rulesets/optimizations.xml/MethodArgumentCouldBeFinal"/>-->
- <!--<rule ref="rulesets/optimizations.xml/AvoidInstantiatingObjectsInLoops"/>-->
- <!--<rule ref="rulesets/optimizations.xml/UseArrayListInsteadOfVector"/>-->
- <!--<rule ref="rulesets/optimizations.xml/SimplifyStartsWith"/>-->
- <rule ref="rulesets/optimizations.xml/UseStringBufferForStringAppends"/>
-
- <!--<rule ref="rulesets/strictexception.xml/AvoidCatchingThrowable"/>-->
- <!--<rule ref="rulesets/strictexception.xml/SignatureDeclareThrowsException"/>-->
- <rule ref="rulesets/strictexception.xml/ExceptionAsFlowControl"/>
- <!--<rule ref="rulesets/strictexception.xml/AvoidCatchingNPE"/>-->
- <!--<rule ref="rulesets/strictexception.xml/AvoidThrowingRawExceptionTypes"/>-->
- <!--<rule ref="rulesets/strictexception.xml/AvoidThrowingNullPointerException"/>-->
-
- <!--<rule ref="rulesets/strings.xml/AvoidDuplicateLiterals"/>-->
- <rule ref="rulesets/strings.xml/StringInstantiation"/>
- <rule ref="rulesets/strings.xml/StringToString"/>
- <!-- <rule ref="rulesets/strings.xml/AvoidConcatenatingNonLiteralsInStringBuffer"/>-->
- <rule ref="rulesets/strings.xml/UnnecessaryCaseChange"/>
-
- <!--<rule ref="rulesets/sunsecure.xml/MethodReturnsInternalArray"/>-->
- <!--<rule ref="rulesets/sunsecure.xml/ArrayIsStoredDirectly"/>-->
-
- <rule ref="rulesets/unusedcode.xml/UnusedLocalVariable"/>
- <rule ref="rulesets/unusedcode.xml/UnusedPrivateField"/>
- <rule ref="rulesets/unusedcode.xml/UnusedPrivateMethod"/>
- <rule ref="rulesets/unusedcode.xml/UnusedFormalParameter"/>
+ <rule ref="rulesets/java/basic.xml/BooleanInstantiation"/>
+ <rule ref="rulesets/java/basic.xml/CollapsibleIfStatements"/>
+ <rule ref="rulesets/java/basic.xml/DoubleCheckedLocking"/>
+ <!--<rule ref="rulesets/java/basic.xml/EmptyCatchBlock"/>-->
+ <rule ref="rulesets/java/basic.xml/EmptyFinallyBlock"/>
+ <rule ref="rulesets/java/basic.xml/EmptyIfStmt"/>
+ <rule ref="rulesets/java/basic.xml/EmptyStatementNotInLoop"/>
+ <!--<rule ref="rulesets/java/basic.xml/EmptyStaticInitializer"/>-->
+ <!--<rule ref="rulesets/java/basic.xml/EmptySwitchStatements"/>-->
+ <rule ref="rulesets/java/basic.xml/EmptySynchronizedBlock"/>
+ <rule ref="rulesets/java/basic.xml/EmptyTryBlock"/>
+ <!--<rule ref="rulesets/java/basic.xml/EmptyWhileStmt"/>-->
+ <rule ref="rulesets/java/basic.xml/ForLoopShouldBeWhileLoop"/>
+ <rule ref="rulesets/java/basic.xml/JumbledIncrementer"/>
+ <rule ref="rulesets/java/basic.xml/OverrideBothEqualsAndHashcode"/>
+ <rule ref="rulesets/java/basic.xml/ReturnFromFinallyBlock"/>
+ <rule ref="rulesets/java/basic.xml/UnconditionalIfStatement"/>
+ <rule ref="rulesets/java/basic.xml/UnnecessaryConversionTemporary"/>
+ <rule ref="rulesets/java/basic.xml/UnnecessaryFinalModifier"/>
+ <rule ref="rulesets/java/basic.xml/UnnecessaryReturn"/>
+ <!--<rule ref="rulesets/java/basic.xml/UselessOverridingMethod"/>-->
+
+ <!--<rule ref="rulesets/java/braces.xml/ForLoopsMustUseBraces"/>-->
+ <!--<rule ref="rulesets/java/braces.xml/IfElseStmtsMustUseBraces"/>-->
+ <!--<rule ref="rulesets/java/braces.xml/IfStmtsMustUseBraces"/>-->
+ <!--<rule ref="rulesets/java/braces.xml/WhileLoopsMustUseBraces"/>-->
+
+ <!--<rule ref="rulesets/java/clone.xml/CloneMethodMustImplementCloneable"/>-->
+ <!--<rule ref="rulesets/java/clone.xml/CloneThrowsCloneNotSupportedException"/>-->
+ <!--<rule ref="rulesets/java/clone.xml/ProperCloneImplementation"/>-->
+
+ <!--<rule ref="rulesets/java/codesize.xml/CyclomaticComplexity"/>-->
+ <rule ref="rulesets/java/codesize.xml/ExcessiveClassLength"/>
+ <rule ref="rulesets/java/codesize.xml/ExcessiveMethodLength"/>
+ <rule ref="rulesets/java/codesize.xml/ExcessiveParameterList"/>
+ <rule ref="rulesets/java/codesize.xml/ExcessivePublicCount"/>
+ <!--<rule ref="rulesets/java/codesize.xml/TooManyFields"/>-->
+
+ <!--<rule ref="rulesets/java/controversial.xml/AssignmentInOperand"/>-->
+ <!--<rule ref="rulesets/java/controversial.xml/AtLeastOneConstructor"/>-->
+ <!--<rule ref="rulesets/java/controversial.xml/CallSuperInConstructor"/>-->
+ <!--<rule ref="rulesets/java/controversial.xml/DontImportSun"/>-->
+ <!--<rule ref="rulesets/java/controversial.xml/NullAssignment"/>-->
+ <!--<rule ref="rulesets/java/controversial.xml/OnlyOneReturn"/>-->
+ <!--<rule ref="rulesets/java/controversial.xml/SingularField"/>-->
+ <!--<rule ref="rulesets/java/controversial.xml/SuspiciousOctalEscape"/>-->
+ <!--<rule ref="rulesets/java/controversial.xml/UnnecessaryConstructor"/>-->
+ <!--<rule ref="rulesets/java/controversial.xml/UnnecessaryParentheses"/>-->
+ <!--<rule ref="rulesets/java/controversial.xml/UnusedModifier"/>-->
+
+ <!--<rule ref="rulesets/java/coupling.xml/CouplingBetweenObjects"/>-->
+ <!--<rule ref="rulesets/java/coupling.xml/ExcessiveImports"/>-->
+ <!--<rule ref="rulesets/java/coupling.xml/LooseCoupling"/>-->
+
+ <!--<rule ref="rulesets/java/design.xml/AbstractClassWithoutAbstractMethod"/>-->
+ <!--<rule ref="rulesets/java/design.xml/AccessorClassGeneration"/>-->
+ <!--<rule ref="rulesets/java/design.xml/AssignmentToNonFinalStatic"/>-->
+ <!--<rule ref="rulesets/java/design.xml/AvoidDeeplyNestedIfStmts"/>-->
+ <!--<rule ref="rulesets/java/design.xml/AvoidInstanceofChecksInCatchClause"/>-->
+ <rule ref="rulesets/java/design.xml/AvoidProtectedFieldInFinalClass"/>
+ <!--<rule ref="rulesets/java/design.xml/AvoidReassigningParameters"/>-->
+ <!--<rule ref="rulesets/java/design.xml/AvoidSynchronizedAtMethodLevel"/>-->
+ <!--<rule ref="rulesets/java/design.xml/BadComparison"/>-->
+ <!--<rule ref="rulesets/java/design.xml/CloseConnection"/>-->
+ <!--<rule ref="rulesets/java/design.xml/CompareObjectsWithEquals"/>-->
+ <!--<rule ref="rulesets/java/design.xml/ConfusingTernary"/>-->
+ <rule ref="rulesets/java/design.xml/ConstructorCallsOverridableMethod"/>
+ <!--<rule ref="rulesets/java/design.xml/DefaultLabelNotLastInSwitchStmt"/>-->
+ <!--<rule ref="rulesets/java/design.xml/FinalFieldCouldBeStatic"/>-->
+ <rule ref="rulesets/java/design.xml/IdempotentOperations"/>
+ <!--<rule ref="rulesets/java/design.xml/ImmutableField"/>-->
+ <!--<rule ref="rulesets/java/design.xml/InstantiationToGetClass"/>-->
+ <!--<rule ref="rulesets/java/design.xml/MissingBreakInSwitch"/>-->
+ <!--<rule ref="rulesets/java/design.xml/MissingStaticMethodInNonInstantiatableClass"/>-->
+ <!--<rule ref="rulesets/java/design.xml/NonCaseLabelInSwitchStatement"/>-->
+ <!--<rule ref="rulesets/java/design.xml/NonStaticInitializer"/>-->
+ <rule ref="rulesets/java/design.xml/OptimizableToArrayCall"/>
+ <rule ref="rulesets/java/design.xml/PositionLiteralsFirstInComparisons"/>
+ <!--rule ref="rulesets/java/design.xml/SimplifyBooleanExpressions"/-->
+ <rule ref="rulesets/java/design.xml/SimplifyBooleanReturns"/>
+ <rule ref="rulesets/java/design.xml/SimplifyConditional"/>
+ <!--<rule ref="rulesets/java/design.xml/SwitchDensity"/>-->
+ <!--<rule ref="rulesets/java/design.xml/SwitchStmtsShouldHaveDefault"/>-->
+ <rule ref="rulesets/java/design.xml/UnnecessaryLocalBeforeReturn"/>
+ <!--<rule ref="rulesets/java/design.xml/UseLocaleWithCaseConversions"/>-->
+ <!--<rule ref="rulesets/java/design.xml/UseNotifyAllInsteadOfNotify"/>-->
+ <!--<rule ref="rulesets/java/design.xml/UseSingleton"/>-->
+
+ <!--<rule ref="rulesets/java/finalizers.xml/EmptyFinalizer"/>-->
+ <!--<rule ref="rulesets/java/finalizers.xml/FinalizeOnlyCallsSuperFinalize"/>-->
+ <!--<rule ref="rulesets/java/finalizers.xml/FinalizeOverloaded"/>-->
+ <!--<rule ref="rulesets/java/finalizers.xml/FinalizeDoesNotCallSuperFinalize"/>-->
+ <!--<rule ref="rulesets/java/finalizers.xml/FinalizeShouldBeProtected"/>-->
+ <rule ref="rulesets/java/finalizers.xml/AvoidCallingFinalize"/>
+
+ <rule ref="rulesets/java/imports.xml/DuplicateImports"/>
+ <rule ref="rulesets/java/imports.xml/DontImportJavaLang"/>
+ <rule ref="rulesets/java/imports.xml/UnusedImports"/>
+ <rule ref="rulesets/java/imports.xml/ImportFromSamePackage"/>
+
+ <!--<rule ref="rulesets/java/javabeans.xml/BeanMembersShouldSerialize"/>-->
+ <!--<rule ref="rulesets/java/javabeans.xml/MissingSerialVersionUID"/>-->
+
+ <!--<rule ref="rulesets/java/junit.xml/JUnitStaticSuite"/>-->
+ <!--<rule ref="rulesets/java/junit.xml/JUnitSpelling"/>-->
+ <!--<rule ref="rulesets/java/junit.xml/JUnitAssertionsShouldIncludeMessage"/>-->
+ <!--<rule ref="rulesets/java/junit.xml/JUnitTestsShouldIncludeAssert"/>-->
+ <!--<rule ref="rulesets/java/junit.xml/TestClassWithoutTestCases"/>-->
+ <!--<rule ref="rulesets/java/junit.xml/UnnecessaryBooleanAssertion"/>-->
+ <!--<rule ref="rulesets/java/junit.xml/UseAssertEqualsInsteadOfAssertTrue"/>-->
+ <!--<rule ref="rulesets/java/junit.xml/UseAssertSameInsteadOfAssertTrue"/>-->
+
+ <rule ref="rulesets/java/logging-java.xml/AvoidPrintStackTrace"/>
+ <rule ref="rulesets/java/logging-java.xml/LoggerIsNotStaticFinal"/>
+ <!--<rule ref="rulesets/java/logging-java.xml/MoreThanOneLogger"/>-->
+ <!--<rule ref="rulesets/java/logging-java.xml/LoggerIsNotStaticFinal"/>-->
+ <!--<rule ref="rulesets/java/logging-java.xml/LogBlockWithoutIf"/>-->
+ <!--<rule ref="rulesets/java/logging-java.xml/SystemPrintln"/>-->
+ <!--<rule ref="rulesets/java/logging-jakarta-commons.xml/UseCorrectExceptionLogging"/>-->
+ <!--<rule ref="rulesets/java/logging-jakarta-commons.xml/ProperLogger"/>-->
+
+ <!--<rule ref="rulesets/java/naming.xml/ShortVariable"/>-->
+ <!--<rule ref="rulesets/java/naming.xml/LongVariable"/>-->
+ <!--<rule ref="rulesets/java/naming.xml/ShortMethodName"/>-->
+ <!--<rule ref="rulesets/java/naming.xml/VariableNamingConventions"/>-->
+ <rule ref="rulesets/java/naming.xml/MethodNamingConventions"/>
+ <rule ref="rulesets/java/naming.xml/ClassNamingConventions"/>
+ <!--<rule ref="rulesets/java/naming.xml/AbstractNaming"/>-->
+ <!--<rule ref="rulesets/java/naming.xml/AvoidDollarSigns"/>-->
+ <!--<rule ref="rulesets/java/naming.xml/MethodWithSameNameAsEnclosingClass"/>-->
+ <!--<rule ref="rulesets/java/naming.xml/SuspiciousHashcodeMethodName"/>-->
+ <!--<rule ref="rulesets/java/naming.xml/SuspiciousConstantFieldName"/>-->
+ <!--<rule ref="rulesets/java/naming.xml/AvoidFieldNameMatchingTypeName"/>-->
+ <!--<rule ref="rulesets/java/naming.xml/AvoidFieldNameMatchingMethodName"/>-->
+ <!-- <rule ref="rulesets/java/naming.xml/AvoidNonConstructorMethodsWithClassName"/> -->
+ <rule ref="rulesets/java/naming.xml/NoPackage"/>
+ <rule ref="rulesets/java/naming.xml/PackageCase"/>
+
+ <!--<rule ref="rulesets/java/optimizations.xml/LocalVariableCouldBeFinal"/>-->
+ <!--<rule ref="rulesets/java/optimizations.xml/MethodArgumentCouldBeFinal"/>-->
+ <!--<rule ref="rulesets/java/optimizations.xml/AvoidInstantiatingObjectsInLoops"/>-->
+ <!--<rule ref="rulesets/java/optimizations.xml/UseArrayListInsteadOfVector"/>-->
+ <!--<rule ref="rulesets/java/optimizations.xml/SimplifyStartsWith"/>-->
+ <rule ref="rulesets/java/optimizations.xml/UseStringBufferForStringAppends"/>
+
+ <!--<rule ref="rulesets/java/strictexception.xml/AvoidCatchingThrowable"/>-->
+ <!--<rule ref="rulesets/java/strictexception.xml/SignatureDeclareThrowsException"/>-->
+ <rule ref="rulesets/java/strictexception.xml/ExceptionAsFlowControl"/>
+ <!--<rule ref="rulesets/java/strictexception.xml/AvoidCatchingNPE"/>-->
+ <!--<rule ref="rulesets/java/strictexception.xml/AvoidThrowingRawExceptionTypes"/>-->
+ <!--<rule ref="rulesets/java/strictexception.xml/AvoidThrowingNullPointerException"/>-->
+
+ <!--<rule ref="rulesets/java/strings.xml/AvoidDuplicateLiterals"/>-->
+ <rule ref="rulesets/java/strings.xml/StringInstantiation"/>
+ <rule ref="rulesets/java/strings.xml/StringToString"/>
+ <!-- <rule ref="rulesets/java/strings.xml/AvoidConcatenatingNonLiteralsInStringBuffer"/>-->
+ <rule ref="rulesets/java/strings.xml/UnnecessaryCaseChange"/>
+
+ <!--<rule ref="rulesets/java/sunsecure.xml/MethodReturnsInternalArray"/>-->
+ <!--<rule ref="rulesets/java/sunsecure.xml/ArrayIsStoredDirectly"/>-->
+
+ <rule ref="rulesets/java/unusedcode.xml/UnusedLocalVariable"/>
+ <rule ref="rulesets/java/unusedcode.xml/UnusedPrivateField"/>
+ <rule ref="rulesets/java/unusedcode.xml/UnusedPrivateMethod"/>
+ <rule ref="rulesets/java/unusedcode.xml/UnusedFormalParameter"/>
</ruleset>
Modified: mahout/trunk/pom.xml
URL: http://svn.apache.org/viewvc/mahout/trunk/pom.xml?rev=1500160&r1=1500159&r2=1500160&view=diff
==============================================================================
--- mahout/trunk/pom.xml (original)
+++ mahout/trunk/pom.xml Fri Jul 5 23:00:04 2013
@@ -101,6 +101,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<mpmd.version>3.0.1</mpmd.version>
<mcheckstyle.version>2.10</mcheckstyle.version>
+ <mfindbugs.version>2.5.2</mfindbugs.version>
<hadoop.version>1.1.2</hadoop.version>
<lucene.version>4.3.0</lucene.version>
</properties>
@@ -578,68 +579,6 @@
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-checkstyle-plugin</artifactId>
- <version>${mcheckstyle.version}</version>
- <dependencies>
- <dependency>
- <groupId>org.apache.mahout</groupId>
- <artifactId>mahout-buildtools</artifactId>
- <version>${project.version}</version>
- </dependency>
- </dependencies>
- <executions>
- <execution>
- <id>validate</id>
- <phase>validate</phase>
- <configuration>
- <configLocation>../buildtools/src/main/resources/mahout-checkstyle.xml</configLocation>
- <consoleOutput>true</consoleOutput>
- <failsOnError>false</failsOnError>
- <linkXRef>false</linkXRef>
- <sourceDirectory>${basedir}/src</sourceDirectory>
- </configuration>
- <goals>
- <goal>checkstyle</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-pmd-plugin</artifactId>
- <version>${mpmd.version}</version>
- <dependencies>
- <dependency>
- <groupId>org.apache.mahout</groupId>
- <artifactId>mahout-buildtools</artifactId>
- <version>${project.version}</version>
- </dependency>
- </dependencies>
- <configuration>
- <rulesets>
- <!-- classpath -->
- <ruleset>../buildtools/src/main/resources/mahout-pmd-ruleset.xml</ruleset>
- </rulesets>
- <!-- targetJdk is explicitly set until MPMD-170 is resolved -->
- <targetJdk>${maven.compiler.target}</targetJdk>
- <linkXRef>false</linkXRef>
- <includeTests>true</includeTests>
- <verbose>true</verbose>
- </configuration>
- <!--
- <executions>
- <execution>
- <id>validate</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- </execution>
- </executions>
- -->
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.14.1</version>
</plugin>
@@ -706,6 +645,53 @@
<artifactId>maven-clover2-plugin</artifactId>
<version>3.1.11.1</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${mcheckstyle.version}</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.mahout</groupId>
+ <artifactId>mahout-buildtools</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-pmd-plugin</artifactId>
+ <version>${mpmd.version}</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.mahout</groupId>
+ <artifactId>mahout-buildtools</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+ <configuration>
+ <rulesets>
+ <!-- classpath -->
+ <ruleset>mahout-pmd-ruleset.xml</ruleset>
+ </rulesets>
+ <!-- targetJdk is explicitly set until MPMD-170 is resolved -->
+ <targetJdk>${maven.compiler.target}</targetJdk>
+ <linkXRef>false</linkXRef>
+ <includeTests>true</includeTests>
+ <verbose>true</verbose>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <version>${mfindbugs.version}</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.mahout</groupId>
+ <artifactId>mahout-buildtools</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+ </plugin>
</plugins>
<resources>
<resource>
@@ -816,12 +802,65 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <version>${mcheckstyle.version}</version>
+ <executions>
+ <execution>
+ <id>sourcecheck</id>
+ <phase>verify</phase>
+ <goals>
+ <goal>checkstyle</goal>
+ </goals>
+ <configuration>
+ <failsOnError>false</failsOnError>
+ <!-- classpath -->
+ <configLocation>mahout-checkstyle.xml</configLocation>
+ <consoleOutput>true</consoleOutput>
+ <linkXRef>false</linkXRef>
+ <sourceDirectory>${basedir}/src</sourceDirectory>
+ </configuration>
+ </execution>
+ </executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
- <version>${mpmd.version}</version>
+ <executions>
+ <execution>
+ <id>sourcecheck</id>
+ <phase>verify</phase>
+ <goals>
+ <goal>check</goal>
+ <goal>cpd-check</goal>
+ </goals>
+ <configuration>
+ <failOnViolation>false</failOnViolation>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>sourcecheck</id>
+ <phase>verify</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ <configuration>
+ <xmlOutput>true</xmlOutput>
+ <threshold>Low</threshold>
+ <effort>Default</effort>
+ <!--visitors>FindDeadLocalStores,UnreadFields</visitors-->
+ <!--omitVisitors>FindDeadLocalStores,UnreadFields</omitVisitors-->
+ <debug>true</debug>
+ <relaxed>true</relaxed>
+ <!-- classpath -->
+ <excludeFilterFile>findbugs-exclude.xml</excludeFilterFile>
+ <failOnError>false</failOnError>
+ </configuration>
+ </execution>
+ </executions>
</plugin>
</plugins>
</build>
@@ -880,7 +919,8 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${mcheckstyle.version}</version>
<configuration>
- <configLocation>${project.build.directory}/../../buildtools/src/main/resources/mahout-checkstyle.xml</configLocation>
+ <!-- classpath -->
+ <configLocation>mahout-checkstyle.xml</configLocation>
<consoleOutput>true</consoleOutput>
</configuration>
</plugin>
@@ -910,7 +950,8 @@
<version>${mpmd.version}</version>
<configuration>
<rulesets>
- <ruleset>../buildtools/src/main/resources/mahout-pmd-ruleset.xml</ruleset>
+ <!-- classpath -->
+ <ruleset>mahout-pmd-ruleset.xml</ruleset>
</rulesets>
<targetJdk>${maven.compiler.target}</targetJdk>
<linkXRef>false</linkXRef>
@@ -934,18 +975,17 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
- <version>2.5.2</version>
+ <version>${mfindbugs.version}</version>
<configuration>
<xmlOutput>true</xmlOutput>
- <xmlOutputDirectory>target/findbugs</xmlOutputDirectory>
- <outputDirectory>target/site/findbugs</outputDirectory>
<threshold>Low</threshold>
<effort>Default</effort>
<!--visitors>FindDeadLocalStores,UnreadFields</visitors-->
<!--omitVisitors>FindDeadLocalStores,UnreadFields</omitVisitors-->
<debug>true</debug>
<relaxed>true</relaxed>
- <excludeFilterFile>../buildtools/src/main/resources/findbugs-exclude.xml</excludeFilterFile>
+ <!-- classpath -->
+ <excludeFilterFile>findbugs-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>