[GitHub] [arrow-datafusion] domodwyer commented on a change in pull request #1539: approx_quantile() aggregation function

[GitBox <gi...@apache.org>]

domodwyer commented on a change in pull request #1539:
URL: https://github.com/apache/arrow-datafusion/pull/1539#discussion_r782321200



##########
File path: datafusion/src/physical_plan/mod.rs
##########
@@ -640,6 +640,7 @@ pub mod sort;
 pub mod sort_preserving_merge;
 pub mod stream;
 pub mod string_expressions;
+pub(crate) mod tdigest;

Review comment:
       I modelled `approx_quantile()` after `approx_count()` which uses `HyperLogLog` internally - the `hyperloglog` mod is also `pub(crate)` so I did the same - I can change tdigest to `pub` if that makes more sense?
   
   Should `hyperloglog` also be `pub`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org