You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/13 18:38:29 UTC

[GitHub] [arrow] wjones127 commented on a diff in pull request #33620: GH-33619: [Documentation] Update PR template

wjones127 commented on code in PR #33620:
URL: https://github.com/apache/arrow/pull/33620#discussion_r1069845277


##########
.github/pull_request_template.md:
##########
@@ -50,7 +48,7 @@ We typically require tests for all PRs in order to:
 If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
 -->
 
-# Are there any user-facing changes?
+### Are there any user-facing changes?

Review Comment:
   Another piece of feedback:
   
   1. The `breaking-change` label didn't exist. I decided to add it as `Breaking Change` just now, since there isn't a good reason to kebab-case AFAIK.
   2. I don't think non-committers can apply labels, right? So perhaps the instructions simply need to have a checkbox `[ ] This PR contains breaking changes` or something like that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org