You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/04/17 14:09:11 UTC

[GitHub] [parquet-mr] leoluan2009 opened a new pull request #894: [WIP] Refactor GroupReadSupport to remove deprecated api

leoluan2009 opened a new pull request #894:
URL: https://github.com/apache/parquet-mr/pull/894


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky commented on pull request #894: [WIP] Refactor GroupReadSupport to remove deprecated api

Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #894:
URL: https://github.com/apache/parquet-mr/pull/894#issuecomment-826928341


   This is a breaking change that our build (japicmp maven plugin) should have been caught. I've tried to investigate and reported a bug for the plugin.
   Also, this change has a WIP in the header and no JIRA links. I'm going to revert this change.
   
   @leoluan2009, please create a jira for this and open a new PR with correcting backward incompatible change (deprecate public methods instead of removing/overwriting them)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky commented on pull request #894: [WIP] Refactor GroupReadSupport to remove deprecated api

Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #894:
URL: https://github.com/apache/parquet-mr/pull/894#issuecomment-827377131


   I've overlooked this change which is syntactically not a breaking change as both methods (the deleted and the new one) are overridden from the parent. That's why the plugin did not identify this change.
   Meanwhile, the super implementation of the removed method throws an `UnsupportedOperationException` so by removing it in the descendant is a breaking change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #894: [WIP] Refactor GroupReadSupport to remove deprecated api

Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #894:
URL: https://github.com/apache/parquet-mr/pull/894#issuecomment-824989695


   LGTM. Thanks for working on it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli merged pull request #894: [WIP] Refactor GroupReadSupport to remove deprecated api

Posted by GitBox <gi...@apache.org>.
shangxinli merged pull request #894:
URL: https://github.com/apache/parquet-mr/pull/894


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org