You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/10/01 02:19:51 UTC
Re: Review Request 38608: Added an http::Connection for connection
re-use and pipelining.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38608/
-----------------------------------------------------------
(Updated Oct. 1, 2015, 12:19 a.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Some simplifications driven by vinod's feedback.
Summary (updated)
-----------------
Added an http::Connection for connection re-use and pipelining.
Bugs: MESOS-3332
https://issues.apache.org/jira/browse/MESOS-3332
Repository: mesos
Description
-------
In order to support connection re-use and pipelining of requests on a shared connection, this introduces the notion of an http::Connection.
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416
3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015
3rdparty/libprocess/src/tests/http_tests.cpp c380f356548cf9f5491044bccabcd9c66ad5f55a
Diff: https://reviews.apache.org/r/38608/diff/
Testing
-------
Added tests.
Thanks,
Ben Mahler
Re: Review Request 38608: Added an http::Connection for connection
re-use and pipelining.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 5, 2015, 11 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/http.cpp, line 783
> > <https://reviews.apache.org/r/38608/diff/4/?file=1089303#file1089303line783>
> >
> > s/`socket_`/`_socket`/?
> >
> > underscore suffix makes it more look like a member (Google style).
Agreed, I think we need to do a sweep though because the majority of our code still uses underscore as ' (prime): socket'
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38608/#review101540
-----------------------------------------------------------
On Oct. 3, 2015, 12:04 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38608/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 12:04 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3332
> https://issues.apache.org/jira/browse/MESOS-3332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to support connection re-use and pipelining of requests on a shared connection, this introduces the notion of an http::Connection.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416
> 3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015
> 3rdparty/libprocess/src/tests/http_tests.cpp c380f356548cf9f5491044bccabcd9c66ad5f55a
>
> Diff: https://reviews.apache.org/r/38608/diff/
>
>
> Testing
> -------
>
> Added tests.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38608: Added an http::Connection for connection
re-use and pipelining.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38608/#review101540
-----------------------------------------------------------
LGTM! Nice tests!
3rdparty/libprocess/src/http.cpp (line 783)
<https://reviews.apache.org/r/38608/#comment158961>
s/`socket_`/`_socket`/?
underscore suffix makes it more look like a member (Google style).
3rdparty/libprocess/src/http.cpp (line 979)
<https://reviews.apache.org/r/38608/#comment158963>
Owned, instead of a raw pointer? Save a 'delete' in `~Data()`.
3rdparty/libprocess/src/tests/http_tests.cpp (line 721)
<https://reviews.apache.org/r/38608/#comment158972>
Remove one extra blank line here.
- Jie Yu
On Oct. 3, 2015, 12:04 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38608/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 12:04 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3332
> https://issues.apache.org/jira/browse/MESOS-3332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to support connection re-use and pipelining of requests on a shared connection, this introduces the notion of an http::Connection.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416
> 3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015
> 3rdparty/libprocess/src/tests/http_tests.cpp c380f356548cf9f5491044bccabcd9c66ad5f55a
>
> Diff: https://reviews.apache.org/r/38608/diff/
>
>
> Testing
> -------
>
> Added tests.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38608: Added an http::Connection for connection
re-use and pipelining.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38608/#review101548
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Oct. 3, 2015, 12:04 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38608/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 12:04 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3332
> https://issues.apache.org/jira/browse/MESOS-3332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to support connection re-use and pipelining of requests on a shared connection, this introduces the notion of an http::Connection.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416
> 3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015
> 3rdparty/libprocess/src/tests/http_tests.cpp c380f356548cf9f5491044bccabcd9c66ad5f55a
>
> Diff: https://reviews.apache.org/r/38608/diff/
>
>
> Testing
> -------
>
> Added tests.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38608: Added an http::Connection for connection
re-use and pipelining.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38608/
-----------------------------------------------------------
(Updated Oct. 3, 2015, 12:04 a.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Fixed a compilation issue on OS X.
Bugs: MESOS-3332
https://issues.apache.org/jira/browse/MESOS-3332
Repository: mesos
Description
-------
In order to support connection re-use and pipelining of requests on a shared connection, this introduces the notion of an http::Connection.
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416
3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015
3rdparty/libprocess/src/tests/http_tests.cpp c380f356548cf9f5491044bccabcd9c66ad5f55a
Diff: https://reviews.apache.org/r/38608/diff/
Testing
-------
Added tests.
Thanks,
Ben Mahler
Re: Review Request 38608: Added an http::Connection for connection
re-use and pipelining.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38608/
-----------------------------------------------------------
(Updated Oct. 2, 2015, 11:49 p.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Close the socket upon send error.
Bugs: MESOS-3332
https://issues.apache.org/jira/browse/MESOS-3332
Repository: mesos
Description
-------
In order to support connection re-use and pipelining of requests on a shared connection, this introduces the notion of an http::Connection.
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416
3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015
3rdparty/libprocess/src/tests/http_tests.cpp c380f356548cf9f5491044bccabcd9c66ad5f55a
Diff: https://reviews.apache.org/r/38608/diff/
Testing
-------
Added tests.
Thanks,
Ben Mahler