You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Justin Ross (JIRA)" <ji...@apache.org> on 2016/11/04 16:37:59 UTC
[jira] [Updated] (PROTON-946) remove generated data structure
definitions from protocol.h
[ https://issues.apache.org/jira/browse/PROTON-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Ross updated PROTON-946:
-------------------------------
Fix Version/s: Future
> remove generated data structure definitions from protocol.h
> -----------------------------------------------------------
>
> Key: PROTON-946
> URL: https://issues.apache.org/jira/browse/PROTON-946
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: 0.10
> Reporter: michael goulish
> Assignee: michael goulish
> Fix For: Future
>
>
> Currently protocol.h.py reads the AMQP 1.0 spec xml files and generates all of its output into protocol.h -- even the data structure definitions.
> Those definitions are currently protected by #ifdef DEFINE_FIELDS , which is defined only in codec.c -- so the definitions only show up in that file, while other .c files only see the declarations.
> If DEFINE_FIELDS is #defined in any other file, compilation will fail with multiple definition errors.
> The structure declarations should remain in the .h file , but the actual definitions should be moved into a generated .c file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org