You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/16 00:48:52 UTC
[GitHub] aaronmarkham opened a new pull request #12195: [MXNet-744] Fix
website build pipeline Python 3 issues
aaronmarkham opened a new pull request #12195: [MXNet-744] Fix website build pipeline Python 3 issues
URL: https://github.com/apache/incubator-mxnet/pull/12195
## Description ##
Some Python 3 incompatibilities existed in the website build pipeline. When CI was updated to run docs build in Python 3 mode these surfaced. This PR addresses it and locks in the Python dependency versions to help prevent future breakage.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
* Fixed Sphinx plugin mxdoc.py Python 3 issues by using `six`.
* Added `six` to dependencies
* Consolidated Python requirements for docs to one file in `ci/docker/install`
* Pinned dependencies to specific version numbers
* `mock` was not pinned upstream from docs, so we were getting a later version than what docs had been pinned to, so this is upgraded.
* "Upgraded" a variety of packages that were not pinned to the latest in PyPI. Tests indicate things are good, and I'd rather pin things now to prevent future breakage.
* Added a separate `Jenkinsfile-dev` so I don't have to keep hacking the Jenkinsfile every time I need to test something from my fork. This way I can just point to it from the test Jenkins jobs directly, and no more code updates.
* Updated CI's docker images to use the new Python requirements file
## Comments ##
* We can break out a separate requirements file if some split in deps appears between Python 2/3. For now the packages are the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services