You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jan Høydahl (JIRA)" <ji...@apache.org> on 2018/05/30 13:32:00 UTC
[jira] [Commented] (LUCENE-5143) rm or formalize dealing with
"general" KEYS files in our dist dir
[ https://issues.apache.org/jira/browse/LUCENE-5143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495158#comment-16495158 ]
Jan Høydahl commented on LUCENE-5143:
-------------------------------------
Uploaded an updated KEYS file with Cao's GPG key.
Do you guys feel confident that the changes are safe (i.e. the various verifications proved above, including the latest verify.sh), or do you need other tests?
I can commit this now before 7.4.0
> rm or formalize dealing with "general" KEYS files in our dist dir
> -----------------------------------------------------------------
>
> Key: LUCENE-5143
> URL: https://issues.apache.org/jira/browse/LUCENE-5143
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Hoss Man
> Assignee: Jan Høydahl
> Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: KEYS, KEYS, KEYS, KEYS, LUCENE-5143.patch, LUCENE-5143.patch, LUCENE-5143.patch, LUCENE-5143_READMEs.patch, LUCENE-5143_READMEs.patch, LUCENE-5143_READMEs.patch, LUCENE_5143_KEYS.patch, verify.log, verify.sh, verify.sh
>
>
> At some point in the past, we started creating a snapshots of KEYS (taken from the auto-generated data from id.apache.org) in the release dir of each release...
> http://www.apache.org/dist/lucene/solr/4.4.0/KEYS
> http://www.apache.org/dist/lucene/java/4.4.0/KEYS
> http://archive.apache.org/dist/lucene/java/4.3.0/KEYS
> http://archive.apache.org/dist/lucene/solr/4.3.0/KEYS
> etc...
> But we also still have some "general" KEYS files...
> https://www.apache.org/dist/lucene/KEYS
> https://www.apache.org/dist/lucene/java/KEYS
> https://www.apache.org/dist/lucene/solr/KEYS
> ...which (as i discovered when i went to add my key to them today) are stale and don't seem to be getting updated.
> I vaguely remember someone (rmuir?) explaining to me at one point the reason we started creating a fresh copy of KEYS in each release dir, but i no longer remember what they said, and i can't find any mention of a reason in any of the release docs, or in any sort of comment in buildAndPushRelease.py
> we probably do one of the following:
> * remove these "general" KEYS files
> * add a disclaimer to the top of these files that they are legacy files for verifying old releases and are no longer used for new releases
> * ensure these files are up to date stop generating per-release KEYS file copies
> * update our release process to ensure that the general files get updated on each release as well
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org