[jira] [Created] (ZEPPELIN-2457) Empty Commit to (Git) Version Control after paragraph change

["Alexander Wenzel (JIRA)" <ji...@apache.org>]

Alexander Wenzel created ZEPPELIN-2457:
------------------------------------------

             Summary: Empty Commit to (Git) Version Control after paragraph change
                 Key: ZEPPELIN-2457
                 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2457
             Project: Zeppelin
          Issue Type: Bug
    Affects Versions: 0.7.0
            Reporter: Alexander Wenzel
            Priority: Critical


We are working with GIT version control and have encountered some strange behavior 
regarding commits (changes being lost, commits being empty).

Now we were able to invest some time to look into it and were able to reliably reproduce it:


h3. BUG:
---
When editing a paragraph and then commiting via "Version Control" Button in Zeppelin Toolbar, 
an empty commit will be performed (containing no changes at all).

Similarly, when editing a paragraph, then running the paragraph, then editing it again 
and then commiting via "Version Control" Button in Zeppelin Toolbar, 
the commit will only contain the changes before running the paragraph.

We took some look into the websocket frames being sent:
While editing the paragraph, only "PING" frames were sent.
The Commit Button only sent one "CHECKPOINT_NOTE" frame, which does not contain any paragraph text.


h3. Current Workarounds:
---
Perform one of the following actions before commiting:

## 1) Changing the paragraph title
^ will send websocket frame (containing the changes):
 "op":"COMMIT_PARAGRAPH"

## 2) Running the changed paragraph
^ will send websocket frame (containing the changes):
 "op":"RUN_PARAGRAPH"

## 3) Running all paragraphs (of the notebook)
^ will send websocket frame (containing the changes):
 "op":"RUN_ALL_PARAGRAPHS"


h3. Proposed Bug Fix:
---
Triggering a Commit via "Version Control" Button in Zeppelin Toolbar 
should send a "COMMIT_PARAGRAPH" websocket frame (similar to the one, when changing a paragraph title).

Please note this is only a proposal based on our observation on the websocket frames being exchanged. Any solution is welcome :)

If you need any further infos, please ask.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)