You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by po...@apache.org on 2021/05/09 21:14:13 UTC

[airflow] branch master updated: Fix argument ordering and type of bucket and object (#15738)

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/master by this push:
     new 3711a29  Fix argument ordering and type of bucket and object (#15738)
3711a29 is described below

commit 3711a29e5e253ede4ab12efe5990e83240e8a9a9
Author: Steven van Rossum <sj...@google.com>
AuthorDate: Sun May 9 23:14:00 2021 +0200

    Fix argument ordering and type of bucket and object (#15738)
---
 airflow/providers/google/cloud/hooks/gcs.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/airflow/providers/google/cloud/hooks/gcs.py b/airflow/providers/google/cloud/hooks/gcs.py
index a4341ec..63e6081 100644
--- a/airflow/providers/google/cloud/hooks/gcs.py
+++ b/airflow/providers/google/cloud/hooks/gcs.py
@@ -265,8 +265,8 @@ class GCSHook(GoogleBaseHook):
 
     def download(
         self,
+        bucket_name: str,
         object_name: str,
-        bucket_name: Optional[str],
         filename: Optional[str] = None,
         chunk_size: Optional[int] = None,
         timeout: Optional[int] = DEFAULT_TIMEOUT,
@@ -280,10 +280,10 @@ class GCSHook(GoogleBaseHook):
         returns the location. For file sizes that exceed the available memory it is recommended
         to write to a file.
 
-        :param object_name: The object to fetch.
-        :type object_name: str
         :param bucket_name: The bucket to fetch from.
         :type bucket_name: str
+        :param object_name: The object to fetch.
+        :type object_name: str
         :param filename: If set, a local file path where the file should be written to.
         :type filename: str
         :param chunk_size: Blob chunk size.