You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/01/10 21:19:00 UTC
[jira] [Commented] (HDFS-16886) Fix documentation for StateStoreRecordOperations#get(Class ..., Query ...)
[ https://issues.apache.org/jira/browse/HDFS-16886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656974#comment-17656974 ]
ASF GitHub Bot commented on HDFS-16886:
---------------------------------------
simbadzina opened a new pull request, #5290:
URL: https://github.com/apache/hadoop/pull/5290
HDFS-16886: Fixes error in documentation for StateStoreRecordsOperations.
### Description of PR
For StateStoreRecordOperations#get(Class ..., Query ...), when multiple records match, the documentation says a null value should be returned and an IOException should be thrown. Both can't happen.
I believe the intended behavior is that an IOException is thrown. This is the implementation in StateStoreBaseImpl.
### How was this patch tested?
No test. Just a simple documentation change.
### For code changes:
> Fix documentation for StateStoreRecordOperations#get(Class ..., Query ...)
> --------------------------------------------------------------------------
>
> Key: HDFS-16886
> URL: https://issues.apache.org/jira/browse/HDFS-16886
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Trivial
>
> For {*}StateStoreRecordOperations#get(Class ..., Query ...){*}, when multiple records match, the documentation says a null value should be returned and an IOException should be thrown. Both can't happen.
> I believe the intended behavior is that an IOException is thrown. This is the implementation in {*}StateStoreBaseImpl{*}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org