You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/01/20 21:11:32 UTC

[GitHub] [thrift] jviotti commented on pull request #2312: [skip ci] Clarify Compact Protocol var int encoding definition

jviotti commented on pull request #2312:
URL: https://github.com/apache/thrift/pull/2312#issuecomment-763948802


   Also, related to this: The specification says that:
   
   > But while the binary protocol encodes the int64 in 8 bytes in big endian order, the compact protocol encodes it in little endian order - this is due to an early implementation bug that finally became the de-facto standard.
   
   But I'm not sure if this is 100% accurate. The var int encoding scheme that Thrift is using takes a Big Endian integer, but the result is technically Little Endian. What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org