You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/08/23 14:43:41 UTC

[GitHub] [accumulo] dlmarion commented on a change in pull request #2240: Prevent compactions from starting when deleting a table

dlmarion commented on a change in pull request #2240:
URL: https://github.com/apache/accumulo/pull/2240#discussion_r694038072



##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java
##########
@@ -82,6 +82,14 @@ public long isReady(long tid, Manager manager) throws Exception {
           TableOperation.COMPACT, TableOperationExceptionType.OTHER, "Compaction canceled");
     }
 
+    String deleteMarkerPath = Constants.ZROOT + "/" + manager.getInstanceID() + Constants.ZTABLES
+        + "/" + tableId + Constants.ZTABLE_DELETE_MARKER;
+    if (zoo.exists(deleteMarkerPath, null)) {

Review comment:
       It would appear that `ZooKeeper.exists` returns `null` when a NONODE exception is returned by the ZK Server to the client. ZooReader returns false when null is returned.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org