You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/23 11:28:40 UTC

[GitHub] [shardingsphere] hitnewbee opened a new pull request #5768: fix #4784

hitnewbee opened a new pull request #5768:
URL: https://github.com/apache/shardingsphere/pull/5768


   Fixes #4784 .
   
   Changes proposed in this pull request:
   
   judgement for insertstatement whether column and value match before route.
   covered:
   1.set statement
   2.default column
   3.designate columns
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu edited a comment on pull request #5768: fix #4784

Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on pull request #5768:
URL: https://github.com/apache/shardingsphere/pull/5768#issuecomment-633552425


   > Do you mean we should let sql execute and get error message from backend database then
   > process it with suitable message and tell user ?
   > And error packet with db proxy
   
   Yes, just like regular JDBC and database report the error.
   
   > where i can find an example for this?
   
   There is no example for now. Maybe you need to find out which SQLException will throw if SQL is wrong for jdbc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter commented on pull request #5768: fix #4784

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5768:
URL: https://github.com/apache/shardingsphere/pull/5768#issuecomment-633035628


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5768?src=pr&el=h1) Report
   > Merging [#5768](https://codecov.io/gh/apache/shardingsphere/pull/5768?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d07e6aa3f542432b3f807e61db95d724b3b05681&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5768/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5768?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5768      +/-   ##
   ============================================
   - Coverage     53.04%   53.00%   -0.04%     
     Complexity      437      437              
   ============================================
     Files          1178     1178              
     Lines         20721    20734      +13     
     Branches       3736     3743       +7     
   ============================================
     Hits          10991    10991              
   - Misses         9059     9072      +13     
     Partials        671      671              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5768?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...che/shardingsphere/infra/route/DataNodeRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/5768/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3JvdXRlL0RhdGFOb2RlUm91dGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5768?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5768?src=pr&el=footer). Last update [d07e6aa...64d5626](https://codecov.io/gh/apache/shardingsphere/pull/5768?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] hitnewbee commented on pull request #5768: fix #4784

Posted by GitBox <gi...@apache.org>.
hitnewbee commented on pull request #5768:
URL: https://github.com/apache/shardingsphere/pull/5768#issuecomment-633172695


   > This pr maybe misunderstand the original meaning.
   > We need to throw suitable SQLException for JDBC-driver and return suitable error packet with db proxy.
   > ShardingSphereException is not a suitable SQLException, and this pr missing to return suitable error packet with db proxy.
   
   Still a little confuse.
   Base on the comment for this issue, i think it is about to block sql that not qualified in shardingsphere.
   Do you mean we should let sql execute and get error message from backend database then process it with suitable message and tell user ?
   And error packet with db proxy
   where i can find an example for this?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] hitnewbee closed pull request #5768: fix #4784

Posted by GitBox <gi...@apache.org>.
hitnewbee closed pull request #5768:
URL: https://github.com/apache/shardingsphere/pull/5768


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] hitnewbee commented on pull request #5768: fix #4784

Posted by GitBox <gi...@apache.org>.
hitnewbee commented on pull request #5768:
URL: https://github.com/apache/shardingsphere/pull/5768#issuecomment-633755985


   Got it, I will reopen PR util finish it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] hitnewbee edited a comment on pull request #5768: fix #4784

Posted by GitBox <gi...@apache.org>.
hitnewbee edited a comment on pull request #5768:
URL: https://github.com/apache/shardingsphere/pull/5768#issuecomment-633172695


   > This pr maybe misunderstand the original meaning.
   > We need to throw suitable SQLException for JDBC-driver and return suitable error packet with db proxy.
   > ShardingSphereException is not a suitable SQLException, and this pr missing to return suitable error packet with db proxy.
   
   @terrymanu 
   Still a little confuse.
   Base on the comment for this issue, i think it is about to block sql that not qualified in shardingsphere.
   Do you mean we should let sql execute and get error message from backend database then process it with suitable message and tell user ?
   And error packet with db proxy
   where i can find an example for this?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on pull request #5768: fix #4784

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #5768:
URL: https://github.com/apache/shardingsphere/pull/5768#issuecomment-633552425


   > Do you mean we should let sql execute and get error message from backend database then
   > process it with suitable message and tell user ?
   > And error packet with db proxy
   
   Yes, just like regular JDBC and database report the error.
   
   > where i can find an example for this?
   There is no example for now. Maybe you need to find out which SQLException will throw if SQL is wrong for jdbc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org