You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2015/02/24 22:57:22 UTC

Review Request 31382: Various zookeeper test fixes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31382/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Various zookeeper test fixes.

Remove static const Duration in favour of a static method.
Add ZooKeeperTest::TearDown and ensure it's called.
Add a couple of TODOs for likely std::unique_ptr candidates.


Diffs
-----

  src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
  src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 
  src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6 
  src/tests/state_tests.cpp b8cddc5fa530aa465d5575e0136e9c89c2b04b58 
  src/tests/zookeeper.hpp d8f1cb345040121368094d1e6d55ddaa791f0e31 
  src/tests/zookeeper.cpp 08cab86d148edf0cae3aaebfda30c21a75bca2b2 
  src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 

Diff: https://reviews.apache.org/r/31382/diff/


Testing
-------

make check GTEST_FILTER='Group*.Zoo*'


Thanks,

Dominic Hamon

Re: Review Request 31382: Various zookeeper test fixes.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31382/#review73934
-----------------------------------------------------------


Patch looks great!

Reviews applied: [31382]

All tests passed.

- Mesos ReviewBot


On Feb. 24, 2015, 9:57 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31382/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 9:57 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Various zookeeper test fixes.
> 
> Remove static const Duration in favour of a static method.
> Add ZooKeeperTest::TearDown and ensure it's called.
> Add a couple of TODOs for likely std::unique_ptr candidates.
> 
> 
> Diffs
> -----
> 
>   src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
>   src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 
>   src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6 
>   src/tests/state_tests.cpp b8cddc5fa530aa465d5575e0136e9c89c2b04b58 
>   src/tests/zookeeper.hpp d8f1cb345040121368094d1e6d55ddaa791f0e31 
>   src/tests/zookeeper.cpp 08cab86d148edf0cae3aaebfda30c21a75bca2b2 
>   src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 
> 
> Diff: https://reviews.apache.org/r/31382/diff/
> 
> 
> Testing
> -------
> 
> make check GTEST_FILTER='Group*.Zoo*'
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>