You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/07/11 02:25:22 UTC
[GitHub] zeppelin pull request #1159: [Test branch] Logout
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1159
[Test branch] Logout
### What is this PR for?
This is a test branch related to #1140
This won't be merged
### What type of PR is it?
Bug Fix
### How should this be tested?
Login and Logout
### Screenshots (if appropriate)
Firefox - Grunt Serve

Firefox - Grunt Build

Chrome - Grunt Serve

Chrome - Grunt Build

Safari - Grunt Serve

Safari - Grunt Build

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin test/logout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1159
----
commit 1c72643c6d1831585350ba197e0e944fa12b0fd6
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-11T02:20:11Z
Change call to logout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1159: [Test branch] Logout
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1159
@prabhjyotsingh If we can remove it, then maybe it would be nice to do so in the future.
Especially since it makes the code more complicated.
For now, let's go with #1140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1159: [Test branch] Logout
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1159
Agreed @corneadoug. Thought we don't have `authcBasic` in our doc, but whoever knows or had used shiro in past can choose to use it, and IMO whatever features shiro provides we should be able to leverage them as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1159: [Test branch] Logout
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1159
I don't have a strong view on any, fine either way. Just that I thought authcBasic should work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1159: [Test branch] Logout
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1159
This works perfectly with `/** = authc`, but #1140 was for fixing `/** = authcBasic`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1159: [Test branch] Logout
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1159: [Test branch] Logout
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1159
@prabhjyotsingh Oh, that's tricky, my initial comment was about authc.
The fun thing is that authcBasic isn't even in the doc, nor as choice in the shiro.ini anymore. Do we still need it? Even pressing cancel on that alert send you to the authc home page.
After testing them all here is the result:
#1140 - Both authc and authcBasic works
Master - Both `authc grunt serve` and `authcBasic grunt serve` do not work
This PR - `authcBasic` and `authcBasic grunt serve` do not work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---