You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/22 08:47:30 UTC

[GitHub] [flink] twalthr commented on a change in pull request #8349: [FLINK-12411][table-planner][tests] Workaround limited support of not nullable fields in window aggregation

twalthr commented on a change in pull request #8349: [FLINK-12411][table-planner][tests] Workaround limited support of not nullable fields in window aggregation
URL: https://github.com/apache/flink/pull/8349#discussion_r286377273
 
 

 ##########
 File path: flink-end-to-end-tests/flink-stream-sql-test/src/main/java/org/apache/flink/sql/tests/StreamSQLTestProgram.java
 ##########
 @@ -106,7 +106,7 @@ public static void main(String[] args) throws Exception {
 		String tumbleQuery = String.format(
 			"SELECT " +
 			"  key, " +
-			"  CASE SUM(cnt) / COUNT(*) WHEN 101 THEN 1 ELSE 99 END AS correct, " +
+			"  CASE SUM(cnt) / COUNT(*) WHEN 101 THEN 1 WHEN -1 THEN NULL ELSE 99 END AS correct, " +
 
 Review comment:
   Can you add a comment and link to the related issue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services