You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LucaCappelletti94 (via GitHub)" <gi...@apache.org> on 2026/10/24 10:54:24 UTC
[PR] PostgreSQL: parse `DROP GROUP` [datafusion-sqlparser-rs]
LucaCappelletti94 opened a new pull request, #2712:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2712
PostgreSQL accepts `DROP GROUP [IF EXISTS] name [, ...]` as an alias for `DROP ROLE`.
Sliced out of #2429 to minimize size of both PRs, although they will have some collisions and need a rebase since they are in older external branches and I could not stack them.
PostgreSQL syntax reference https://www.postgresql.org/docs/current/sql-dropgroup.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] PostgreSQL: parse `DROP GROUP` [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2712:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2712#issuecomment-6526617751
Thanks for the review @s5dsn-eqee and @sabir-akhadov-localstack, I will be merging this now.
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] PostgreSQL: parse `DROP GROUP` [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #2712:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2712#issuecomment-6531227652
Just trying to keep up with the onslaught
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] PostgreSQL: parse `DROP GROUP` [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2712:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2712#issuecomment-6383363323
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2712?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.91%. Comparing base ([`b2b4c05`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/b2b4c0506130b633359834130f519925314a4ba2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c38e04b`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/c38e04b2d198b748efc1901ae8f9ddb2e79516a7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2712 +/- ##
==========================================
+ Coverage 81.89% 81.91% +0.01%
==========================================
Files 42 42
Lines 34669 34679 +10
Branches 34669 34679 +10
==========================================
+ Hits 28392 28406 +14
+ Misses 2751 2747 -4
Partials 3526 3526
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2712?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] PostgreSQL: parse `DROP GROUP` [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 merged PR #2712:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] PostgreSQL: parse `DROP GROUP` [datafusion-sqlparser-rs]
Posted by "sabir-akhadov-localstack (via GitHub)" <gi...@apache.org>.
sabir-akhadov-localstack commented on code in PR #2712:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2712#discussion_r4391619019
##########
src/parser/mod.rs:
##########
@@ -8132,7 +8134,7 @@ impl<'a> Parser<'a> {
};
} else {
return self.expected_ref(
- "COLLATION, CONNECTOR, DATABASE, EXTENSION, FUNCTION, INDEX, OPERATOR, POLICY, PROCEDURE, ROLE, SCHEMA, SECRET, SEQUENCE, STAGE, TABLE, TRIGGER, TYPE, VIEW, MATERIALIZED VIEW, USER or WAREHOUSE after DROP",
+ "COLLATION, CONNECTOR, DATABASE, EXTENSION, FUNCTION, GROUP, INDEX, OPERATOR, POLICY, PROCEDURE, ROLE, SCHEMA, SECRET, SEQUENCE, STAGE, TABLE, TRIGGER, TYPE, VIEW, MATERIALIZED VIEW, USER or WAREHOUSE after DROP",
Review Comment:
Non-blocking: on dialects without `supports_drop_group` this now reads `Expected: ... GROUP, ... after DROP, found: GROUP` (the gated test asserts exactly that). Listing GROUP only when the dialect supports it would avoid the contradiction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org