You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:32:31 UTC
Re: Review Request 66855: Changed the 'capacity_' member of
'BoundedHashMap' to non-const.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66855/
-----------------------------------------------------------
(Updated July 3, 2018, 9:32 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
This prevents the assignment operator from being implicitly deleted.
Diffs (updated)
-----
3rdparty/stout/include/stout/boundedhashmap.hpp 09a9b96f0b4a58c718777aa81a11c6ca4fdb6f8c
Diff: https://reviews.apache.org/r/66855/diff/3/
Changes: https://reviews.apache.org/r/66855/diff/2-3/
Testing (updated)
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 66855: Changed the 'capacity_' member of
'BoundedHashMap' to non-const.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66855/#review206228
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On July 17, 2018, 6:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66855/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 6:44 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This prevents the assignment operator from being implicitly deleted.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/boundedhashmap.hpp 09a9b96f0b4a58c718777aa81a11c6ca4fdb6f8c
>
>
> Diff: https://reviews.apache.org/r/66855/diff/4/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 66855: Changed the 'capacity_' member of
'BoundedHashMap' to non-const.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66855/
-----------------------------------------------------------
(Updated July 18, 2018, 1:44 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
This prevents the assignment operator from being implicitly deleted.
Diffs (updated)
-----
3rdparty/stout/include/stout/boundedhashmap.hpp 09a9b96f0b4a58c718777aa81a11c6ca4fdb6f8c
Diff: https://reviews.apache.org/r/66855/diff/4/
Changes: https://reviews.apache.org/r/66855/diff/3-4/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann